Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop net-http01 prow jobs #443

Merged
merged 1 commit into from
May 27, 2024
Merged

drop net-http01 prow jobs #443

merged 1 commit into from
May 27, 2024

Conversation

dprotaso
Copy link
Member

@knative-prow knative-prow bot requested a review from cardil May 23, 2024 14:10
@knative-prow Knative Prow
Copy link

knative-prow bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested a review from evankanderson May 23, 2024 14:10
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 23, 2024
izabelacg
izabelacg reviewed May 27, 2024
View reviewed changes
config/prow/k8s-testgrid/k8s-testgrid.yaml
@@ -88,7 +87,6 @@ dashboards:
- name: knative-extensions-release-1.0
- name: knative-extensions-release-1.1
- name: knative-extensions-release-1.10
- name: knative-extensions-release-1.11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this line removal intentional?

Copy link
Member Author

@dprotaso dprotaso May 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's autogenerated. I believe it is - 1.11 was the last net-http01 release so dropping the jobs as well. With no jobs it's dropping the dashboard

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, got it. Thanks

@izabelacg
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2024
@knative-prow knative-prow bot merged commit ce0b0a7 into knative:main May 27, 2024
17 checks passed
@knative-prow Knative Prow
Copy link

knative-prow bot commented May 27, 2024

@dprotaso: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key net-http01-main.gen.yaml using file ``
  • key net-http01-release-1.11.gen.yaml using file ``
  • key net-http01-release-1.12.gen.yaml using file ``

In response to this:

/assign @ReToCode @skonto

Part of knative/serving#14640

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izabelacg izabelacg izabelacg left review comments

@cardil cardil Awaiting requested review from cardil

@evankanderson evankanderson Awaiting requested review from evankanderson

Assignees

@skonto skonto

@izabelacg izabelacg

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dprotaso @izabelacg @skonto @ReToCode