Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use testgrid's configurator image from gcr.io registry #521

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

dsimansk
Copy link
Contributor

@dsimansk dsimansk commented Sep 27, 2024

  • Use testgrid's configurator image from gcr.io registry

Address issue described in: #520 (comment)

/cc @upodroid in case this's actual source of latest image for testgrid's configurator.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 27, 2024
@cardil
Copy link
Contributor

cardil commented Sep 27, 2024

Looks okay to me. Let @upodroid take a look...

/cc @upodroid

@dsimansk
Copy link
Contributor Author

Just as a sanity check, pull-infra-validate-own-testgrid-yaml will keep failing until image is updated.

@@ -48,7 +48,7 @@ presubmits:
cluster: "prow-build"
spec:
containers:
- image: us-docker.pkg.dev/k8s-infra-prow/images/configurator:v20240405-c76de01869
- image: gcr.io/k8s-prow/configurator:v20240731-a5d9345e59
Copy link
Member

@upodroid upodroid Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use gcr.io/k8s-staging-test-infra/configurator instead? The images were split by the project. I need to create a bumper config for that registry too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @upodroid, updated the PR.

I see in staging there's also :latest image. I wonder if that would work for us, given we only validate/update TestGrid config with that.

@dsimansk
Copy link
Contributor Author

@upodroid @cardil updated per review suggestion to staging image location. PTAL

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2024
Copy link

knative-prow bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

config/Makefile Outdated Show resolved Hide resolved
prow/jobs/custom/infra.yaml Outdated Show resolved Hide resolved
prow/jobs/custom/infra.yaml Outdated Show resolved Hide resolved
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2024
@upodroid
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2024
@upodroid
Copy link
Member

/override pull-infra-validate-own-testgrid-yaml

Copy link

knative-prow bot commented Sep 30, 2024

@upodroid: Overrode contexts on behalf of upodroid: pull-infra-validate-own-testgrid-yaml

In response to this:

/override pull-infra-validate-own-testgrid-yaml

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit 17f51a7 into knative:main Sep 30, 2024
17 checks passed
Copy link

knative-prow bot commented Sep 30, 2024

@dsimansk: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key infra.yaml using file prow/jobs/custom/infra.yaml

In response to this:

  • Use testgrid's configurator image from gcr.io registry

Address issue described in: #520 (comment)

/cc @upodroid in case this's actual source of latest image for testgrid's configurator.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dsimansk dsimansk deleted the pr/configurator-image branch September 30, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants