-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use testgrid's configurator image from gcr.io registry #521
Conversation
Just as a sanity check, |
prow/jobs/custom/infra.yaml
Outdated
@@ -48,7 +48,7 @@ presubmits: | |||
cluster: "prow-build" | |||
spec: | |||
containers: | |||
- image: us-docker.pkg.dev/k8s-infra-prow/images/configurator:v20240405-c76de01869 | |||
- image: gcr.io/k8s-prow/configurator:v20240731-a5d9345e59 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use gcr.io/k8s-staging-test-infra/configurator
instead? The images were split by the project. I need to create a bumper config for that registry too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @upodroid, updated the PR.
I see in staging there's also :latest
image. I wonder if that would work for us, given we only validate/update TestGrid config with that.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/override pull-infra-validate-own-testgrid-yaml |
@upodroid: Overrode contexts on behalf of upodroid: pull-infra-validate-own-testgrid-yaml In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@dsimansk: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Address issue described in: #520 (comment)
/cc @upodroid in case this's actual source of latest image for testgrid's configurator.