Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the helm charts as a base template to scaffold the artifacts #1501

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

houshengbo
Copy link
Contributor

@houshengbo houshengbo commented Jul 21, 2023

No description provided.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 21, 2023
@knative-prow knative-prow bot requested review from matzew and maximilien July 21, 2023 17:54
@houshengbo houshengbo changed the title Add helm charts base Make the helm charts as a base template to scaffold the artifacts Jul 21, 2023
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (333ca00) 79.15% compared to head (b587712) 79.15%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1501   +/-   ##
=======================================
  Coverage   79.15%   79.15%           
=======================================
  Files          40       40           
  Lines        1794     1794           
=======================================
  Hits         1420     1420           
  Misses        272      272           
  Partials      102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets merge this once the nightly job has the new image that include helm/cr

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2023
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@upodroid
Copy link
Member

/hold cancel

Images have been bumped in knative/infra#154

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2023
@knative-prow knative-prow bot merged commit 83850e7 into knative:main Jul 31, 2023
13 checks passed
@houshengbo
Copy link
Contributor Author

/cherry-pick release-1.11

@knative-prow-robot
Copy link
Contributor

@houshengbo: new pull request created: #1512

In response to this:

/cherry-pick release-1.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants