Allow skipping conversion crd update

[skonto]

Changes

• Downstream we need skip the crd update as this is done by OLM. See [TEST-ONLY] [wip] Remove olm env var for conversion openshift-knative/serverless-operator#2597
• We would like to be able to delegate crd updates and only keep the reconciler for validation.

/kind enhancement

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• webhook/OWNERS [skonto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dprotaso]

Why not just delete the conversion webhook controller from your binary?

Using a context options would require re-compilation anyways

[skonto]

Why not just delete the conversion webhook controller from your binary?

We keep this aligned with the knative/operator https://github.com/knative/operator/blob/main/config/crd/bases/operator.knative.dev_knativeservings.yaml#L2470
Not sure what is coming next (if any major change) like moving from v1beta1 to v1 for example. 🤷

[skonto]

@dprotaso wdyth about my last comment?

[dprotaso]

I guess I'm still confused are you looking to skip conversion webhook callbacks or skip the reconciliation that updates the cacert and service path?

If it's the CA cert then don't we have the knobs(options) to change the default secret and properties?

We keep this aligned with the knative/operator https://github.com/knative/operator/blob/main/config/crd/bases/operator.knative.dev_knativeservings.yaml#L2470

I don't think you need to set that - it will default to what the API server supports - which is probably v1 now? v1beta1 and v1 are equivalent (or it was when I last looked)

[dprotaso]

I'm going to close this out - i think downstream it just makes sense to drop the certificate reconciler from the webhook controller

[skonto]

@dprotaso hi,

I guess I'm still confused are you looking to skip conversion webhook callbacks or skip the reconciliation that updates the cacert and service path?

I wanted to skip the update of the CRD (path and bundle) as this is done from another operator. Contents will not much.

v1beta1 and v1 are equivalent (or it was when I last looked)
I'm going to close this out - i think downstream it just makes sense to drop the certificate reconciler from the webhook controller

I wanted to keep this around in case there is a migration to v1, probably not? Knative operator still has a conversion webhook even if it is on v1beta1 for several releases now. Not sure why it is not dropped if we are never going to move further.