-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AuthenticatableType duck type #3056
Add AuthenticatableType duck type #3056
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3056 +/- ##
==========================================
- Coverage 78.75% 78.62% -0.14%
==========================================
Files 189 191 +2
Lines 8872 8934 +62
==========================================
+ Hits 6987 7024 +37
- Misses 1620 1642 +22
- Partials 265 268 +3 ☔ View full report in Codecov by Sentry. |
87dc325
to
8ad286f
Compare
/test unit-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Similar to what we have for Addressables, this PR adds the duck type
AuthenticatableType
for objects, which have aAuthStatus
.In addition it adds a resolver similar to the addressable_resolver to work with this type.