Satisfy linter

[dprotaso]

see individual commits for details

[codecov]

Codecov Report

Attention: Patch coverage is 91.48936% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.30%. Comparing base (23c15c0) to head (69d8f44).
Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
metrics/memstats.go	89.65%	2 Missing and 1 partial ⚠️
apis/testing/roundtrip/roundtrip.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3132      +/-   ##
==========================================
+ Coverage   78.29%   78.30%   +0.01%     
==========================================
  Files         191      191              
  Lines       11186    11192       +6     
==========================================
+ Hits         8758     8764       +6     
  Misses       2162     2162              
  Partials      266      266              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dprotaso]

/assign @skonto

net-contour will work when bump contour and get the newer k8s libs

[skonto]

copyloopvar could be a replacement. See jaegertracing/jaeger#5976. We also use that in the networking linter.

[dprotaso]

we have it already -

pkg/.golangci.yaml

Lines 89 to 90 in b4ff2c1

	# Copyloopvar is a linter detects places where loop variables are copied.
	- copyloopvar

[skonto]

Let me know if you want to add that linter and I can stamp.

[skonto]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dprotaso,skonto]
• apis/OWNERS [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment