[WIP]Poc for the progressive rollout #8354
knative-style.yaml
on: pull_request
style
/
changes
2s
style
/
...
/
Auto-format and Check
27s
style
/
...
/
Lint
5m 1s
style
/
...
/
Do Not Submit
10s
style
/
...
/
shell
0s
style
/
...
/
yaml
33s
style
/
...
/
github_actions
0s
Matrix: style / Golang / Boilerplate Check
Annotations
20 errors and 20 warnings
style / Golang / Auto-format and Check:
cmd/controller/main.go#L1
Please run goimports.
diff --git a/cmd/controller/main.go b/cmd/controller/main.go
index 84e8220..96de466 100644
--- a/cmd/controller/main.go
+++ b/cmd/controller/main.go
@@ -19,6 +19,7 @@ package main
import (
// The set of controllers this controller process runs.
"flag"
+
certificate "knative.dev/networking/pkg/certificates/reconciler"
"knative.dev/pkg/reconciler"
"knative.dev/pkg/signals"
|
style / Golang / Auto-format and Check:
pkg/apis/serving/v1/stagepodautoscaler_defaults.go#L1
Please run goimports.
diff --git a/pkg/apis/serving/v1/stagepodautoscaler_defaults.go b/pkg/apis/serving/v1/stagepodautoscaler_defaults.go
index 25ac64b..ba232c2 100644
--- a/pkg/apis/serving/v1/stagepodautoscaler_defaults.go
+++ b/pkg/apis/serving/v1/stagepodautoscaler_defaults.go
@@ -23,5 +23,5 @@ import (
// SetDefaults sets the default values for the PodAutoscaler.
func (pa *StagePodAutoscaler) SetDefaults(ctx context.Context) {
//pa.Spec.SetDefaults(apis.WithinSpec(ctx))
-
+
}
|
style / Golang / Auto-format and Check:
pkg/reconciler/autoscaling/kpa/controller.go#L1
Please run goimports.
diff --git a/pkg/reconciler/autoscaling/kpa/controller.go b/pkg/reconciler/autoscaling/kpa/controller.go
index bf63e47..2305da7 100644
--- a/pkg/reconciler/autoscaling/kpa/controller.go
+++ b/pkg/reconciler/autoscaling/kpa/controller.go
@@ -18,6 +18,7 @@ package kpa
import (
"context"
+
spainformer "knative.dev/serving/pkg/client/injection/informers/serving/v1/stagepodautoscaler"
"k8s.io/client-go/tools/cache"
|
style / Golang / Auto-format and Check:
pkg/reconciler/autoscaling/kpa/kpa.go#L1
Please run goimports.
diff --git a/pkg/reconciler/autoscaling/kpa/kpa.go b/pkg/reconciler/autoscaling/kpa/kpa.go
index 867ad21..f05e844 100644
--- a/pkg/reconciler/autoscaling/kpa/kpa.go
+++ b/pkg/reconciler/autoscaling/kpa/kpa.go
@@ -19,9 +19,10 @@ package kpa
import (
"context"
"fmt"
- v1 "knative.dev/serving/pkg/apis/serving/v1"
"math"
+ v1 "knative.dev/serving/pkg/apis/serving/v1"
+
"go.opencensus.io/stats"
"go.uber.org/zap"
|
style / Golang / Auto-format and Check:
pkg/reconciler/autoscaling/kpa/scaler.go#L1
Please run goimports.
diff --git a/pkg/reconciler/autoscaling/kpa/scaler.go b/pkg/reconciler/autoscaling/kpa/scaler.go
index 04457d5..40d8895 100644
--- a/pkg/reconciler/autoscaling/kpa/scaler.go
+++ b/pkg/reconciler/autoscaling/kpa/scaler.go
@@ -19,10 +19,11 @@ package kpa
import (
"context"
"fmt"
- v1 "knative.dev/serving/pkg/apis/serving/v1"
"net/http"
"time"
+ v1 "knative.dev/serving/pkg/apis/serving/v1"
+
"knative.dev/pkg/apis/duck"
"knative.dev/pkg/injection/clients/dynamicclient"
"knative.dev/pkg/logging"
|
style / Golang / Auto-format and Check:
pkg/reconciler/configuration/configuration.go#L1
Please run goimports.
diff --git a/pkg/reconciler/configuration/configuration.go b/pkg/reconciler/configuration/configuration.go
index 87572e1..93f7483 100644
--- a/pkg/reconciler/configuration/configuration.go
+++ b/pkg/reconciler/configuration/configuration.go
@@ -19,10 +19,11 @@ package configuration
import (
"context"
"fmt"
- palisters "knative.dev/serving/pkg/client/listers/autoscaling/v1alpha1"
"sort"
"strconv"
+ palisters "knative.dev/serving/pkg/client/listers/autoscaling/v1alpha1"
+
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/equality"
"k8s.io/apimachinery/pkg/api/errors"
|
style / Golang / Auto-format and Check:
pkg/reconciler/configuration/controller.go#L1
Please run goimports.
diff --git a/pkg/reconciler/configuration/controller.go b/pkg/reconciler/configuration/controller.go
index 690f7a6..007cdeb 100644
--- a/pkg/reconciler/configuration/controller.go
+++ b/pkg/reconciler/configuration/controller.go
@@ -18,6 +18,7 @@ package configuration
import (
"context"
+
painformer "knative.dev/serving/pkg/client/injection/informers/autoscaling/v1alpha1/podautoscaler"
"k8s.io/client-go/tools/cache"
|
style / Golang / Auto-format and Check:
pkg/reconciler/revision/controller.go#L1
Please run goimports.
diff --git a/pkg/reconciler/revision/controller.go b/pkg/reconciler/revision/controller.go
index b14804d..b6e8152 100644
--- a/pkg/reconciler/revision/controller.go
+++ b/pkg/reconciler/revision/controller.go
@@ -19,10 +19,11 @@ package revision
import (
"context"
"fmt"
- "k8s.io/client-go/tools/cache"
"net/http"
"time"
+ "k8s.io/client-go/tools/cache"
+
"go.uber.org/zap"
"golang.org/x/time/rate"
cachingclient "knative.dev/caching/pkg/client/injection/client"
|
style / Golang / Auto-format and Check:
pkg/reconciler/service/controller.go#L1
Please run goimports.
diff --git a/pkg/reconciler/service/controller.go b/pkg/reconciler/service/controller.go
index 56e5127..141672d 100644
--- a/pkg/reconciler/service/controller.go
+++ b/pkg/reconciler/service/controller.go
@@ -18,6 +18,7 @@ package service
import (
"context"
+
painformer "knative.dev/serving/pkg/client/injection/informers/autoscaling/v1alpha1/podautoscaler"
cfgmap "knative.dev/serving/pkg/apis/config"
|
style / Golang / Auto-format and Check:
pkg/reconciler/service/resources/serviceorchestrator.go#L1
Please run goimports.
diff --git a/pkg/reconciler/service/resources/serviceorchestrator.go b/pkg/reconciler/service/resources/serviceorchestrator.go
index 67c05a4..3ed82d3 100644
--- a/pkg/reconciler/service/resources/serviceorchestrator.go
+++ b/pkg/reconciler/service/resources/serviceorchestrator.go
@@ -18,9 +18,10 @@ package resources
import (
"fmt"
+ "strconv"
+
"go.uber.org/zap"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
- "strconv"
"knative.dev/pkg/kmeta"
"knative.dev/pkg/ptr"
|
style / Golang / Lint:
pkg/reconciler/serviceorchestrator/serviceorchestrator.go#L64
G601: Implicit memory aliasing in for loop. (gosec)
|
style / Golang / Lint:
pkg/reconciler/serviceorchestrator/serviceorchestrator.go#L69
G601: Implicit memory aliasing in for loop. (gosec)
|
style / Golang / Lint:
pkg/reconciler/serviceorchestrator/serviceorchestrator.go#L85
G601: Implicit memory aliasing in for loop. (gosec)
|
style / Golang / Lint:
pkg/reconciler/serviceorchestrator/serviceorchestrator.go#L171
(*Reconciler).createStagePA - result 0 (error) is always nil (unparam)
|
style / Golang / Lint:
pkg/reconciler/service/service.go#L153
(*Reconciler).previousCreatedRevision - result 1 (bool) is always false (unparam)
|
style / Golang / Lint:
pkg/reconciler/service/service.go#L172
(*Reconciler).serviceOrchestrator - result 0 (*knative.dev/serving/pkg/apis/serving/v1.ServiceOrchestrator) is always nil (unparam)
|
style / Golang / Lint:
pkg/reconciler/service/service.go#L63
field `stagePodAutoscalerLister` is unused (unused)
|
style / Golang / Lint:
pkg/reconciler/service/service.go#L138
func `(*Reconciler).latestCreatedRevision` is unused (unused)
|
style / Golang / Lint:
pkg/reconciler/service/service.go#L925
func `upgradeInProgress` is unused (unused)
|
style / Golang / Lint:
pkg/reconciler/service/service.go#L617
S1019: should use make([]v1.RevisionTarget, 2) instead (gosimple)
|
style / Golang / Boilerplate Check (go)
The following actions uses node12 which is deprecated and will be forced to run on node16: andstor/file-existence-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
style / Golang / Boilerplate Check (go)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/serving/serving. Supported file pattern: go.sum
|
style / Golang / Boilerplate Check (sh)
The following actions uses node12 which is deprecated and will be forced to run on node16: andstor/file-existence-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
style / Golang / Boilerplate Check (sh)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/serving/serving. Supported file pattern: go.sum
|
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/serving/serving. Supported file pattern: go.sum
|
style / Golang / Lint
The following actions uses node12 which is deprecated and will be forced to run on node16: andstor/file-existence-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
style / Golang / Lint:
pkg/apis/serving/v1/stagepodautoscaler_defaults.go#L24
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
style / Golang / Lint:
pkg/apis/serving/v1/serviceorchestrator_defaults.go#L34
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
style / Golang / Lint:
pkg/apis/serving/v1/stagepodautoscaler_lifecycle.go#L44
receiver-naming: receiver name c should be consistent with previous receiver name pa for StagePodAutoscaler (revive)
|
style / Golang / Lint:
pkg/apis/serving/v1/stagepodautoscaler_lifecycle.go#L49
receiver-naming: receiver name c should be consistent with previous receiver name pa for StagePodAutoscaler (revive)
|
style / Golang / Lint:
pkg/apis/serving/v1/stagepodautoscaler_lifecycle.go#L40
unused-parameter: parameter 'asConfig' seems to be unused, consider removing or renaming it as _ (revive)
|
style / Golang / Lint:
pkg/reconciler/serviceorchestrator/controller.go#L34
unused-parameter: parameter 'cmw' seems to be unused, consider removing or renaming it as _ (revive)
|
style / Golang / Lint:
pkg/reconciler/stagepodautoscaler/controller.go#L35
unused-parameter: parameter 'cmw' seems to be unused, consider removing or renaming it as _ (revive)
|
style / Golang / Lint:
pkg/reconciler/service/service.go#L339
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
style / Golang / Lint:
pkg/reconciler/service/service.go#L287
range: should omit 2nd value from range; this loop is equivalent to `for i := range ...` (revive)
|
style / Golang / Lint:
pkg/reconciler/service/service.go#L257
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
|
style / Golang / Lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/serving/serving. Supported file pattern: go.sum
|