fix test

knative · Apr 11, 2024 · 7835476 · 7835476
1 parent 8cfe652
commit 7835476
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/test/e2e/image_pull_error_test.go b/test/e2e/image_pull_error_test.go
@@ -53,7 +53,7 @@ func TestImagePullError(t *testing.T) {
 		cond := r.Status.GetCondition(v1.ConfigurationConditionReady)
 		if cond != nil && !cond.IsUnknown() {
 			if cond.IsFalse() {
-				if cond.Reason == wantCfgReason && (strings.Contains(cond.Message, "Back-off pulling image") || strings.Contains(cond.Message, "manifest unknown")) {
+				if cond.Reason == wantCfgReason && hasPullErrorMsg(cond.Message) {
 					return true, nil
 				}
 			}
@@ -90,3 +90,8 @@ func createLatestConfig(t *testing.T, clients *test.Clients, names test.Resource
 		c.Spec = *v1test.ConfigurationSpec(names.Image)
 	})
 }
+
+func hasPullErrorMsg(msg string) bool {
+	return strings.Contains(msg, "Back-off pulling image") ||
+		strings.Contains(msg, "manifest unknown") || strings.Contains(msg, "failed to pull and unpack image")
+}