Skip to content

Commit

Permalink
Do not delete ingress Secret in tests for internal tls
Browse files Browse the repository at this point in the history
This test relies on trusting certificates as described in
#14609
This is currently not implemented in net-istio, and it's tracked as
knative-extensions/net-istio#1328
  • Loading branch information
mgencur committed May 30, 2024
1 parent 0b363c0 commit c61d2ed
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions test/e2e/systeminternaltls/system_internal_tls_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -227,12 +227,6 @@ func TestTLSCertificateRotation(t *testing.T) {
t.Fatalf("Failed to delete secret %s in system namespacee", config.ServingRoutingCertName)
}
checkEndpointState(t, clients, url)

t.Log("Deleting secret in ingress namespace")
if err := clients.KubeClient.CoreV1().Secrets(ingressNS).Delete(context.Background(), config.ServingRoutingCertName, v1.DeleteOptions{}); err != nil {
t.Fatalf("Failed to delete secret %s in ingress namespacee", config.ServingRoutingCertName)
}
checkEndpointState(t, clients, url)
}

func checkEndpointState(t *testing.T, clients *test.Clients, url *url.URL) {
Expand Down

0 comments on commit c61d2ed

Please sign in to comment.