Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop workaround patch for Istio #14156

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Jul 10, 2023

As per title, this patch drops the workaround patch for Istio.

istio/istio#31084 and #10160 have been resolved already.

@knative-prow
Copy link

knative-prow bot commented Jul 10, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Jul 10, 2023
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 10, 2023
@nak3 nak3 marked this pull request as ready for review July 10, 2023 08:59
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2023
@nak3 nak3 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2023
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (a5c8c2e) 86.25% compared to head (44c0396) 86.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14156      +/-   ##
==========================================
- Coverage   86.25%   86.23%   -0.03%     
==========================================
  Files         199      199              
  Lines       14811    14811              
==========================================
- Hits        12775    12772       -3     
- Misses       1734     1735       +1     
- Partials      302      304       +2     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nak3 nak3 changed the title Drop workaround pach for Istio Drop workaround patch for Istio Jul 10, 2023
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nak3 nak3 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2023
@knative-prow knative-prow bot merged commit 4c76e3b into knative:main Jul 11, 2023
50 checks passed
skonto pushed a commit to skonto/serving that referenced this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants