Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert headless service change from k8s private service #15275

Merged
merged 1 commit into from
May 30, 2024

Conversation

izabelacg
Copy link
Member

@izabelacg izabelacg commented May 29, 2024

Fixes #15267

Proposed Changes

Release Note

NONE

@izabelacg izabelacg self-assigned this May 29, 2024
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 29, 2024
@izabelacg izabelacg removed their assignment May 29, 2024
@knative-prow knative-prow bot requested review from ReToCode and skonto May 29, 2024 16:09
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.79%. Comparing base (7fab945) to head (2b6388e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15275      +/-   ##
==========================================
+ Coverage   84.76%   84.79%   +0.02%     
==========================================
  Files         218      218              
  Lines       13479    13478       -1     
==========================================
+ Hits        11426    11429       +3     
+ Misses       1687     1684       -3     
+ Partials      366      365       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member

GitHub Actions has encountered an internal error when running your job.

weird - i've seen it a bunch of times this morning but the github status page shows no issues

@dprotaso
Copy link
Member

re-running github jobs

@dprotaso
Copy link
Member

/test all

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2024
Copy link

knative-prow bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, izabelacg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2024
@dprotaso
Copy link
Member

/retest

@knative-prow knative-prow bot merged commit f53936b into knative:main May 30, 2024
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Istio periodic tests are failing
2 participants