Skip to content

Conversation

@mattmikolay
Copy link
Contributor

@mattmikolay mattmikolay commented Aug 11, 2025

Description

This PR enables the use of branches with TeamsKit by updating the useMsTeamsAuth hook to include a branch_slug in the encoded state param.

Checklist

  • Tests have been added for new features or major refactors to existing features.

Screenshots or videos

Loom video

@vercel
Copy link

vercel bot commented Aug 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
javascript-ms-teams-connect-example Ready Ready Preview Comment Nov 7, 2025 10:33pm
javascript-nextjs-example Ready Ready Preview Comment Nov 7, 2025 10:33pm
javascript-slack-connect-example Ready Ready Preview Comment Nov 7, 2025 10:33pm
javascript-slack-kit-example Ready Ready Preview Comment Nov 7, 2025 10:33pm

@linear
Copy link

linear bot commented Aug 11, 2025

@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2025

🦋 Changeset detected

Latest commit: d55704b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
ms-teams-connect-example Patch
@knocklabs/react-core Patch
@knocklabs/react Patch
@knocklabs/expo Patch
@knocklabs/react-native Patch
guide-example Patch
nextjs-app-dir-example Patch
nextjs-example Patch
slack-connect-example Patch
slack-kit-example Patch
@knocklabs/expo-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor Author

mattmikolay commented Aug 11, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mattmikolay mattmikolay changed the title Update useMsTeamsAuth hook feat(KNO-9332): enable use of TeamsKit with branches Aug 11, 2025
@linear
Copy link

linear bot commented Aug 11, 2025

@mattmikolay mattmikolay changed the base branch from mattmik-kno-9338-javascript-sdks-add-support-for-x-knock-branch-header-to-js to graphite-base/705 November 7, 2025 22:30
@mattmikolay mattmikolay force-pushed the mattmik-kno-9340-teamskit-include-branch-slug-in-encoded-state-param branch from 9e30f26 to 22676f3 Compare November 7, 2025 22:31
@graphite-app graphite-app bot changed the base branch from graphite-base/705 to main November 7, 2025 22:32
@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.50%. Comparing base (571abb1) to head (d55704b).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #705   +/-   ##
=======================================
  Coverage   65.49%   65.50%           
=======================================
  Files         189      189           
  Lines        7793     7795    +2     
  Branches      956      956           
=======================================
+ Hits         5104     5106    +2     
  Misses       2662     2662           
  Partials       27       27           
Files with missing lines Coverage Δ
...-core/src/modules/ms-teams/hooks/useMsTeamsAuth.ts 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants