jsx) fix observable properties being overwritten with observed values

knockout · Feb 28, 2020 · f7b9711 · f7b9711
1 parent e93a234
commit f7b9711
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 For TODO between alpha and release, see https://github.com/knockout/tko/issues/1
 
+## 👑 `alpha 9` (28 Feb 2020)
+
+* Fix JSX observable properties being overwritten with observed value on the NativeProvider
+
 ## 🐇 `alpha 8.4a` (24 Oct 2019)
 
 * Make the `NativeProvider` less preemptive i.e. allow other bindings to proceed if there are no native (JSX) bindings.  This means `data-bind` and other attributes can be used inside JSX.

diff --git a/packages/utils.jsx/src/JsxObserver.js b/packages/utils.jsx/src/JsxObserver.js
@@ -350,7 +350,7 @@ export class JsxObserver extends LifeCycle {
       toRemove.delete(name)
       if (isObservable(value)) {
         subscriptions.push(
-          value.subscribe(attr => this.setNodeAttribute(node, name, attr)))
+          value.subscribe(attr => this.setNodeAttribute(node, name, value)))
       }
       this.setNodeAttribute(node, name, value)
     }