-
Notifications
You must be signed in to change notification settings - Fork 1
Fix/#91 태그 UI 가로 스크롤 적용 및 SwipeableArea 세로 스크롤 이슈 해결 #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4ff93e3
fix: Chip 텍스트 줄바꿈 방지 및 PlaceListItem 태그 영역 가로 스크롤 적용
leeleeleeleejun e413678
fix: request/PlaceListItem 아이콘 정렬 개선
leeleeleeleejun e843313
fix: SwipeableArea의 overflow-hidden에서 overflow-x-hidden으로 변경
leeleeleeleejun 2de1abb
feat: admin에 images.remotePatterns 추가
leeleeleeleejun 615956f
refactor: admin의 요청 상세페이지에서도 PlaceDetailPage와 같은 패턴 도입
leeleeleeleejun 8936c41
refactor: admin/request/id의 Location component의 Marker icon prop 삭제
leeleeleeleejun e311645
fix: admin/next.config.ts 내 example.com 설정 제거
leeleeleeleejun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 5 additions & 16 deletions
21
apps/admin/src/app/requests/[id]/_components/Description/Description.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,14 @@ | ||
| import { Column, Flex } from '@repo/ui/components/Layout' | ||
| import { Chip } from '@repo/ui/components/Chip' | ||
| import { Text } from '@repo/ui/components/Text' | ||
| import { RequestDetail } from '../../_api/types' | ||
| import type { RequestDetail } from '../../_api/types' | ||
|
|
||
| type Props = { | ||
| description: RequestDetail['description'] | ||
| tags: RequestDetail['tags'] | ||
| } | ||
|
|
||
| export const Description = ({ description, tags }: Props) => { | ||
| export const Description = ({ description }: Props) => { | ||
| return ( | ||
| <Column className={'gap-1.5'}> | ||
| <Text>소개</Text> | ||
| <Text variant={'body2'} className={'whitespace-pre-wrap'}> | ||
| {description} | ||
| </Text> | ||
| <Flex className={'gap-1'}> | ||
| {tags.map((tag) => ( | ||
| <Chip key={tag.id} icon={tag.iconKey} label={tag.name} /> | ||
| ))} | ||
| </Flex> | ||
| </Column> | ||
| <Text variant={'body2'} className={'whitespace-pre-wrap'}> | ||
| {description} | ||
| </Text> | ||
| ) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
apps/admin/src/app/requests/[id]/_components/Section/Section.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import { Column, Flex } from '@repo/ui/components/Layout' | ||
| import { Icon, type IconType } from '@repo/ui/components/Icon' | ||
| import { Text } from '@repo/ui/components/Text' | ||
|
|
||
| type Props = { | ||
| icon: IconType | ||
| title: string | ||
| children: React.ReactNode | ||
| } | ||
|
|
||
| export const Section = ({ icon, title, children }: Props) => ( | ||
| <Column as={'section'} className={'gap-1.5'}> | ||
| <Flex className={'gap-1'}> | ||
| <Icon type={icon} size={16} /> | ||
| <Text as={'h2'} variant={'title3'}> | ||
| {title} | ||
| </Text> | ||
| </Flex> | ||
| {children} | ||
| </Column> | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export { Section } from './Section' |
15 changes: 15 additions & 0 deletions
15
apps/admin/src/app/requests/[id]/_components/Tags/Tags.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| import { Flex } from '@repo/ui/components/Layout' | ||
| import { Chip } from '@repo/ui/components/Chip' | ||
| import type { RequestDetail } from '../../_api/types' | ||
|
|
||
| type Props = { | ||
| tags: RequestDetail['tags'] | ||
| } | ||
|
|
||
| export const Tags = ({ tags }: Props) => ( | ||
| <Flex className={'flex-wrap gap-2'}> | ||
| {tags.map((tag) => ( | ||
| <Chip key={tag.id} icon={tag.iconKey} label={tag.name} /> | ||
| ))} | ||
| </Flex> | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export { Tags } from './Tags' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
환경변수 미설정 시 빈 문자열 hostname 문제
process.env.NEXT_PUBLIC_API_URL_HOST가 설정되지 않은 경우 빈 문자열이 hostname으로 전달되어 Next.js 이미지 최적화가 실패하거나 예상치 못한 보안 문제가 발생할 수 있습니다.🔎 제안하는 수정
환경변수가 설정된 경우에만 패턴 추가:
📝 Committable suggestion
🤖 Prompt for AI Agents