fix: WTO API indicator codes, disable giving panel, update README#371
Merged
fix: WTO API indicator codes, disable giving panel, update README#371
Conversation
The WTO trade handlers used fabricated indicator codes (QR, SPS, TBT, HS_M_0010) that don't exist in the WTO Timeseries API, causing all four RPCs to silently return empty data. Fixes: - Tariffs: HS_M_0010 → TP_A_0010; remove partner param (tariff indicators lack partner dimension, caused 400 error) - Trade flows: split comma-separated indicators into parallel requests (API truncates combined i= values) - Restrictions: rewrite to use tariff overview across 15 major economies (QR API is a separate subscription product) - Barriers: rewrite to use agricultural vs non-agricultural tariff gap analysis (ePing SPS/TBT API is separate subscription) - Handle 204 No Content (valid query, no data) instead of treating as error Also: disable Global Giving panel by default for non-happy variants, update README for BIS + WTO features (PR #363, #364).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QR,SPS,TBT,HS_M_0010) that don't exist in the WTO Timeseries API. Rewritten to use correct codes (TP_A_0010,ITS_MTV_AX,ITS_MTV_AM) and proper API patternsenabled: truein FULL config)What was wrong
HS_M_0010doesn't exist;p=partner param caused 400 (tariffs lack partner dimension)TP_A_0010, remove partner parami=ITS_MTV_AX,ITS_MTV_AMgets truncated by WTO APIQRis a separate API product (/qrs/), not a Timeseries indicatorSPS/TBTare ePing API (separate subscription), not Timeseries indicatorsTest plan