Skip to content

fix(live-news): call destroyPlayer() before offline/embed error message (fixes #347) #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Niboshi-Wasabi wants to merge 4 commits into from
+2 −1
Closed

fix(live-news): call destroyPlayer() before offline/embed error message (fixes #347) #388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0a39ce2
fix(live-news): call destroyPlayer() before offline/embed error messa…
Niboshi-Wasabi Feb 26, 2026
f8c0544
fix: resolve canvas-confetti import error (CDN load + optimizeDeps)
Niboshi-Wasabi Feb 26, 2026
7b481b3
Revert Fix 2 (canvas-confetti); keep only Fix 1 (Issue #347)
Niboshi-Wasabi Feb 26, 2026
a522d74
chore: address review — remove scratch docs, revert celebration.ts to…
Niboshi-Wasabi Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/components/LiveNewsPanel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -733,6 +733,7 @@ export class LiveNewsPanel extends Panel {
}

private showOfflineMessage(channel: LiveChannel): void {
this.destroyPlayer();
this.content.innerHTML = `
<div class="live-offline">
<div class="offline-icon">📺</div>
Expand All @@ -743,6 +744,7 @@ export class LiveNewsPanel extends Panel {
}

private showEmbedError(channel: LiveChannel, errorCode: number): void {
this.destroyPlayer();
const watchUrl = channel.videoId
? `https://www.youtube.com/watch?v=${encodeURIComponent(channel.videoId)}`
: `https://www.youtube.com/${channel.handle}`;
Expand Down
1 change: 0 additions & 1 deletion src/services/celebration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ export function celebrate(type: 'milestone' | 'record' = 'milestone'): void {
disableForReducedMotion: true,
});
} else {
// 'record' -- double burst for extra emphasis
void confetti({
particleCount: 80,
spread: 90,
Expand Down