Skip to content

fix: Sentry triage — CSS selector escape, player.destroy guard, noise filters #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koala73 merged 1 commit into from
Feb 26, 2026
+13 −2
Merged

fix: Sentry triage — CSS selector escape, player.destroy guard, noise filters #402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/search-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ export class SearchManager implements AppModule {

private highlightNewsItem(itemId: string): void {
setTimeout(() => {
const item = document.querySelector(`[data-news-id="${itemId}"]`);
const item = document.querySelector(`[data-news-id="${CSS.escape(itemId)}"]`);
if (item) {
item.scrollIntoView({ behavior: 'smooth', block: 'center' });
item.classList.add('flash-highlight');
Expand Down
2 changes: 1 addition & 1 deletion src/components/LiveNewsPanel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ export class LiveNewsPanel extends Panel {
this.clearBotCheckTimeout();
this.stopMuteSyncPolling();
if (this.player) {
this.player.destroy();
if (typeof this.player.destroy === 'function') this.player.destroy();
this.player = null;
}

Expand Down
11 changes: 11 additions & 0 deletions src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,15 @@ Sentry.init({
/evaluating 'elemFound\.value'/,
/Cannot access '\w+' before initialization/,
/^Uint8Array$/,
/createObjectStore/,
/The database connection is closing/,
/shortcut icon/,
/Attempting to change value of a readonly property/,
/reading 'nodeType'/,
/feature named .pageContext. was not found/,
/a2z\.onStatusUpdate/,
/Attempting to run\(\), but is already running/,
/this\.player\.destroy is not a function/,
],
beforeSend(event) {
const msg = event.exception?.values?.[0]?.value ?? '';
Expand All @@ -113,6 +122,8 @@ Sentry.init({
const appFrames = frames.filter(f => f.in_app && !/\/sentry-[A-Za-z0-9-]+\.js/.test(f.filename ?? ''));
if (appFrames.length > 0 && appFrames.every(f => /\/(map|maplibre|deck-stack)-[A-Za-z0-9-]+\.js/.test(f.filename ?? ''))) return null;
}
// Suppress errors originating entirely from blob: URLs (browser extensions)
if (frames.length > 0 && frames.every(f => /^blob:/.test(f.filename ?? ''))) return null;
// Suppress YouTube IFrame widget API internal errors
if (frames.some(f => /www-widgetapi\.js/.test(f.filename ?? ''))) return null;
// Suppress Sentry SDK internal crashes (logs.js)
Expand Down