Skip to content

Fix JSON1 repeated comments across multiple files #3398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koalaman merged 1 commit into from
Feb 1, 2026
+1 −1
Merged

Fix JSON1 repeated comments across multiple files #3398

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ShellCheck/Formatter/JSON1.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ collectResult ref cr sys = mapM_ f groups
let filename = sourceFile (NE.head group)
result <- siReadFile sys (Just True) filename
let contents = either (const "") id result
let comments' = makeNonVirtual comments contents
let comments' = makeNonVirtual (NE.toList group) contents
deepseq comments' $ modifyIORef ref (\x -> comments' ++ x)

finish ref = do
Expand Down
Loading