Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoreport ignores non-numeric values in numeric field #186

Merged

Conversation

noliveleger
Copy link
Contributor

fixes #185

@noliveleger noliveleger requested review from jnm and removed request for jnm December 6, 2018 21:28
@noliveleger
Copy link
Contributor Author

Not ready yet. Tests are failing!

@noliveleger noliveleger requested a review from jnm December 6, 2018 21:50
@coveralls
Copy link

coveralls commented Dec 8, 2018

Coverage Status

Coverage increased (+0.1%) to 82.768% when pulling ff19064 on 185-autoreport-crashes-with-non-numeric-in-numeric-field into dc06fd7 on master.

@jnm
Copy link
Member

jnm commented Dec 17, 2018

Per discussion with @noliveleger, this is superseded by #187 and likely will not be merged.

that responses of the wrong type can be treated as "not provided"
@jnm jnm merged commit 09c600f into master Feb 4, 2019
@jnm jnm deleted the 185-autoreport-crashes-with-non-numeric-in-numeric-field branch February 4, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create autoreport even when non-numeric value exists in numeric field
3 participants