Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRF==3.6.4, added explicit fields for some ModelSerializers - fixes #397 #399

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeverling
Copy link
Contributor

Django REST Framework 3.6 contains some fixes, for example using a source parameter with a Serializer e.g. serializers.CharField(source='json.username', default=None, allow_null=True) fails gracefully with DRF 3.6 while it raises an exception with DRF 3.3.2.
It is necessary to explicitly add fields = '__all__' to ModelSerializer instances that neither set fields or exclude, but as far as I can tell that only applied to NoteSerializer and MetaDataSerializer.

@jeverling
Copy link
Contributor Author

Fixes #397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant