Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent SKIP_HEAVY_MIGRATIONS warning unless running the relevant migrations #894

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Prevent SKIP_HEAVY_MIGRATIONS warning unless running the relevant migrations #894

merged 1 commit into from
Sep 8, 2023

Conversation

LMNTL
Copy link
Contributor

@LMNTL LMNTL commented Sep 7, 2023

Description

Refactors main.0011_drop_old_kpi_tables to not print a heavy migration warning every time Django loads the migration file (e.g. when running ./manage.py migrate for an unrelated app).

@LMNTL LMNTL requested a review from bufke September 8, 2023 14:36
bufke
bufke approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@bufke bufke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this by running with and without this patch. It removed the unhelpful warning as expected. The message in 0028_populate_daily_xform_counters_for_year is similar but doesn't have the same problem of always showing the warning.

@bufke bufke merged commit fd97f98 into beta Sep 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bufke bufke bufke approved these changes

Assignees
No one assigned
Labels
backend bug-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LMNTL @bufke