Make changes discussed during review of #3689 #3693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noliveleger
approved these changes
Feb 22, 2022
| @@ -573,7 +573,8 @@ class Meta(ReadOnlyModel.Meta): | |||
| mimetype = models.CharField( | |||
| max_length=100, null=False, blank=True, default='' | |||
| ) | |||
| replaced_at = models.DateTimeField(blank=True, null=True) | |||
| # TODO: hide attachments that were deleted or replaced | |||
| # replaced_at = models.DateTimeField(blank=True, null=True) | |||
There was a problem hiding this comment.
| @@ -512,7 +512,7 @@ def test_surveys_exported_to_xml_have_id_string_and_title(self): | |||
| asset_type='survey') | |||
| export = a1.snapshot | |||
| self.assertTrue('<h:title>abcxyz</h:title>' in export.xml) | |||
| self.assertTrue('<data id="xid_stringx">' in export.xml) | |||
| self.assertTrue(f'<{a1.uid} id="xid_stringx">' in export.xml) | |||
| if self.include_format_suffixes: | ||
| urls = format_suffix_patterns(urls) | ||
|
|
||
| urls.extend(alias_urls) |
noliveleger
reviewed
Feb 22, 2022
| @@ -588,13 +591,15 @@ def get_attachment( | |||
| raise XPathNotFoundException | |||
|
|
|||
| filters = { | |||
| 'replaced_at': None, | |||
| # TODO: hide attachments that were deleted or replaced | |||
There was a problem hiding this comment.
noliveleger
reviewed
Feb 22, 2022
| 'instance_id': submission_id, | ||
| 'media_file_basename': attachment_filename, | ||
| } | ||
| else: | ||
| filters = { | ||
| 'replaced_at': None, | ||
| # TODO: hide attachments that were deleted or replaced | ||
| # 'replaced_at': None, |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.