-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove runsv
and KoboCAT uWSGI env variables
#4948
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noliveleger
changed the title
Refactor kobo docker env vars
Remove May 24, 2024
runsv
and KoboCAT uWSGI env variables
noliveleger
force-pushed
the
refactor-kobo-docker-env-vars
branch
2 times, most recently
from
May 27, 2024 16:34
a8a1c40
to
a0faa19
Compare
noliveleger
force-pushed
the
refactor-kobo-docker-env-vars
branch
from
May 27, 2024 20:41
7233aae
to
6f6e761
Compare
This was referenced May 28, 2024
Drop CSV import support from API v1
Make image attachments resizing work again
Fix race conditions while running migrations for fresh installs
jnm
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moreover
KPI_
prefix has been also removed. Container does not rely onrunsv
to handle Celery processes.Notes
Since everything is running under the same Python application, uWSGI env variables for KoboCAT were obsolete.
KPI_WEB_SERVER
WSGI
KPI_UWSGI_HARAKIRI
UWSGI_HARAKIRI
KPI_UWSGI_WORKER_RELOAD_MERCY
UWSGI_WORKER_RELOAD_MERCY
KPI_UWSGI_WORKERS_COUNT
UWSGI_WORKERS_COUNT
KPI_UWSGI_CHEAPER_WORKERS_COUNT
UWSGI_CHEAPER_WORKERS_COUNT
KPI_UWSGI_CHEAPER_RSS_LIMIT_SOFT
UWSGI_CHEAPER_RSS_LIMIT_SOFT
KPI_UWSGI_MAX_REQUESTS
UWSGI_MAX_REQUESTS
KPI_UWSGI_RELOAD_ON_RSS_MB
UWSGI_RELOAD_ON_RSS_MB
Same other variables were deprecated and have been replaced too.
ENKETO_API_TOKEN
ENKETO_API_KEY
RAVEN_DSN
SENTRY_DSN
KPI_CELERY_BROKER_URL
CELERY_BROKER_URL
Moreover
runsv
has been removed.uWSGI
is now the main process.Related issues
related to #4888
blocked by kobotoolbox/kobo-install#241
blocked by kobotoolbox/kobo-docker#347