Add django-import-export for organization users #4986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnm
requested changes
Sep 13, 2024
There was a problem hiding this comment.
The changes look fine, but the PR description does not reflect well what the code actually does. See my comment on https://www.notion.so/kobotoolbox/Import-billing-users-in-bulk-c389e89af9b94606af6fef069facf850.
I have not run the branch and tested the new functionality.
jnm
changed the title
jnm
added a commit
that referenced
this pull request
Oct 3, 2024
Add subdependencies that were missing from #4986, presumably as a result of manually editing `*requirements.txt` files instead of running `pip-compile.sh`
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Django admin can now import and export organization users to and from formats including csv.
Notes
It's a common need to import and export users. Django-import-export provides a customizable way to do so with minimal code. It's IMO a well maintained package but does occasionally include minor breaking changes, such as the 4.x release.
This change took about 45 minutes and was tested with importing Organization Users.