-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy contextTypes #4997
Commits on Jul 4, 2024
-
Remove legacy React contextTypes
This removes some legacy api deprecation notices in the console in React 18. - Replace the last this.context.router in projectSettings.es6 with this.props.router from withRouter HOC. (Tested this, works fine) - Remove these, which are unused: SomeComponent.contextTypes = { router: PropTypes.object };
Configuration menu - View commit details
-
Copy full SHA for 3000ea5 - Browse repository at this point
Copy the full SHA 3000ea5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6dbcace - Browse repository at this point
Copy the full SHA 6dbcaceView commit details -
reactBemComponents .es6 -> .tsx
Doing this step in one commit, hoping it will make the diff easier to review online.
Configuration menu - View commit details
-
Copy full SHA for 17e8759 - Browse repository at this point
Copy the full SHA 17e8759View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b3c6f9 - Browse repository at this point
Copy the full SHA 5b3c6f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1995b1a - Browse repository at this point
Copy the full SHA 1995b1aView commit details
Commits on Jul 5, 2024
-
Install eslint-plugin-import for separate type import statements…
e.g., not say 'duplicate import' for this code: import React from 'react' import type { ReactNode } from 'react' …which used to work fine, but typescript-eslint's no-duplicate-imports rule has been removed: - typescript-eslint/typescript-eslint@47eeea9275bd - https://typescript-eslint.io/rules/no-duplicate-imports/ We could do more with this plugin. Only skimmed it, but some of the other features might require some more config. - https://github.com/import-js/eslint-plugin-import/blob/main/README.md#resolvers (Meanwhile, I'll try not to think about how many dev dependencies we bring in just for this cool rule.)
Configuration menu - View commit details
-
Copy full SHA for ad79423 - Browse repository at this point
Copy the full SHA ad79423View commit details -
Refinements after testing KoboMatrix
- Remove modifier='[object Object]' in generated bem elements - Use the new React 18 root API in renderInBackbone
Configuration menu - View commit details
-
Copy full SHA for e4056df - Browse repository at this point
Copy the full SHA e4056dfView commit details
Commits on Jul 17, 2024
-
Merge pull request #5000 from kobotoolbox/eslint-type-duplicate-imports
Update ESLint config to accept separate type imports in TS again
Configuration menu - View commit details
-
Copy full SHA for bd881d9 - Browse repository at this point
Copy the full SHA bd881d9View commit details
Commits on Jul 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 78e1ece - Browse repository at this point
Copy the full SHA 78e1eceView commit details