New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ESLint config to accept separate type imports in TS again #5000

Merged

magicznyleszek merged 1 commit into remove-context-types from eslint-type-duplicate-imports

Jul 17, 2024

Commits on Jul 5, 2024

Install eslint-plugin-import for separate type import statements…

e.g., not say 'duplicate import' for this code:

   import React from 'react'
   import type { ReactNode } from 'react'

…which used to work fine, but typescript-eslint's no-duplicate-imports
rule has been removed:

- typescript-eslint/typescript-eslint@47eeea9275bd
- https://typescript-eslint.io/rules/no-duplicate-imports/

We could do more with this plugin.

Only skimmed it, but some of the other features might require some
more config.

- https://github.com/import-js/eslint-plugin-import/blob/main/README.md#resolvers

(Meanwhile, I'll try not to think about how many dev dependencies
we bring in just for this cool rule.)

p2edwards committed Jul 5, 2024