Code refactoring: Remove kobo_service_account dependency
#5045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
noliveleger
force-pushed
the
kobocat-django-app-part-2-remove-service-account
branch
from
509758b
to
72ea390
Compare
noliveleger
changed the base branch from
kobocat-django-app-part-2
to
kobocat-django-app-part-2-remove-kobocat-rest-service
…into kobocat-django-app-part-2-remove-service-account
Base automatically changed from
kobocat-django-app-part-2-remove-kobocat-rest-service
to
kobocat-django-app-part-2
August 23, 2024 23:26
…end' into kobocat-django-app-part-2-handle-missing-xform
…bocat-django-app-part-2-better-error-handling
…-2-remove-service-account
…kobocat-django-app-part-2-refactor-mock-deployment-backend
…end' into kobocat-django-app-part-2-handle-missing-xform
…bocat-django-app-part-2-better-error-handling
…end' into kobocat-django-app-part-2-handle-missing-xform
…bocat-django-app-part-2-better-error-handling
jnm
requested changes
Sep 6, 2024
kobo/apps/openrosa/apps/api/tests/viewsets/test_abstract_viewset.py
Outdated
Show resolved
Hide resolved
noliveleger
force-pushed
the
kobocat-django-app-part-2-remove-service-account
branch
from
35d29e9
to
59a00a6
Compare
noliveleger
force-pushed
the
kobocat-django-app-part-2-remove-service-account
branch
from
59a00a6
to
41c6b73
Compare
…efactor-mock-deployment-backend Code refactoring: Simplify MockDeploymentBackend
…kobocat-django-app-part-2-handle-missing-xform
…bocat-django-app-part-2-better-error-handling
…andle-missing-xform Code refactoring: Improve error message when XForm does not exist
…etter-error-handling Code refactoring: Better error handling in new deployment back-end class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part V of #5036.
Remove dependency on kobo-service-account package.
Since there is no proxy between KPI and KoboCAT anymore, it is not needed anymore.
Notes
https://github.com/kobotoolbox/kobo-service-account should be archived once this PR is merged.
Related issues
Part of #5036