Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK-1059] Handle submission groups in Access Log UI #5116

Open
wants to merge 23 commits into
base: TASK-869-group-at-fetch
Choose a base branch
from

Conversation

magicznyleszek
Copy link
Member

@magicznyleszek magicznyleszek commented Sep 18, 2024

Checklist

  1. If you've added code that should be tested, add tests
  2. If you've changed APIs, update (or create!) the documentation
  3. Ensure the tests pass
  4. Make sure that your code lints and that you've followed our coding style
  5. Write a title and, if necessary, a description of your work suitable for publishing in our release notes
  6. Mention any related issues in this repository (as #ISSUE) and in other repositories (as kobotoolbox/other#ISSUE)
  7. Open an issue in the docs if there are UI/UX changes

Description

Displays the "Data submissions (n)" type of access log properly in the UI.

Notes

I had to change how UniversalTable is handling the cellFormatter function. Now it receives whole original data object instead of just getting the key property value. This way we can display whatever we want.

I also updated the types for the API response, as it changed slightly.

Related issues

Build atop #5094 (TASK-869-group-submissions-better) and #5109 (task857-access-log-ui) - we need to merge both of these first, before this PR can be merged. In reality there is only one small commit of changes here.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants