refactor(projects): deduplicate code via UniversalProjectsRoute #5251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create UniversalProjectsRoute and use it for all routes move transfer modal and banner code outside MyProjectsRoute
9 tasks
jamesrkiger
reviewed
Nov 12, 2024
jsapp/js/components/permissions/transferProjects/inviteBanner.tsx
Outdated
Show resolved
Hide resolved
jamesrkiger
reviewed
Nov 12, 2024
jsapp/js/components/permissions/transferProjects/transferModalWithBanner.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📣 Summary
Use single universal component for My Projects (
#/projects/home) and Custom Project Views (#/projects/<uid>) routes.💭 Notes
Move transfer project ownership code from
myProjectsRouteto separate component - logic gathered inProjectOwnershipTransferModalWithBannercomponent and banner inProjectTransferInviteBannercomponent.Create
UniversalProjectsRoutecomponent that gathers similar logic from bothMyProjectsRouteandCustomViewRoute. To not increase complexity of the code deduplication is done under assumption that all routes wants (almost) all the same functionalities.This change is done for upcoming organizations feature.