Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(profiles): faster profile images and Option to remove img and clear profile #10434

Merged
merged 23 commits into from
Jul 9, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Jun 8, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

❗️❗️ Needs https://github.com/kodadot/private-workers/pull/177
❗️❗️ Needs kodadot/workers#300

Needs QA check

  • @kodadot/qa-guild please review

Needs Design check

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

CleanShot 2024-06-12 at 12 35 24

CleanShot 2024-06-14 at 10 29 30@2x

Copy link

netlify bot commented Jun 8, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit d9d88b8
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/668bb83b3eb79000087efb2b
😎 Deploy Preview https://deploy-preview-10434--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vikiival vikiival added this to the Profile launch milestone Jun 12, 2024
Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hassnian
Copy link
Contributor Author

worker ready https://github.com/kodadot/private-workers/pull/187

blocked by #10534

@hassnian hassnian marked this pull request as ready for review July 1, 2024 05:20
@hassnian hassnian requested a review from a team as a code owner July 1, 2024 05:20
@hassnian hassnian requested review from preschian and removed request for a team July 1, 2024 05:20
@hassnian hassnian requested a review from Jarsen136 July 1, 2024 05:20
@hassnian
Copy link
Contributor Author

hassnian commented Jul 3, 2024

@exezbcz it's ready to test

Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wfm

@hassnian
Copy link
Contributor Author

hassnian commented Jul 5, 2024

@Jarsen136 can I get a review , thanks

@exezbcz
Copy link
Member

exezbcz commented Jul 6, 2024

it does not let me save empty profile picture,

image

otherwise really nice job, toast notifs works nice

@hassnian
Copy link
Contributor Author

hassnian commented Jul 6, 2024

@vikiival ready to merge

@vikiival
Copy link
Member

vikiival commented Jul 8, 2024

Will go after

@vikiival
Copy link
Member

vikiival commented Jul 8, 2024

@hassnian you have some conflicts

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/@braintree/sanitize-url@6.0.4

View full report↗︎

Copy link

codeclimate bot commented Jul 8, 2024

Code Climate has analyzed commit d9d88b8 and detected 0 issues on this pull request.

View more on Code Climate.

@hassnian
Copy link
Contributor Author

hassnian commented Jul 8, 2024

@hassnian you have some conflicts

done

@vikiival vikiival added this pull request to the merge queue Jul 9, 2024
Merged via the queue into kodadot:main with commit 90fd200 Jul 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants