Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add accept ranges #188

Closed
wants to merge 7 commits into from
Closed

fix: add accept ranges #188

wants to merge 7 commits into from

Conversation

preschian
Copy link
Member

@preschian preschian commented Oct 20, 2023 •
edited
Loading

@preschian
Copy link
Member Author

maybe anyone knows @kodadot/internal-dev

It seems like some different spec headers on Apple devices. I already tried to adjust and compare some headers with cf-ipfs still fails

will try it again with this c498a75 on canary env

@preschian
Copy link
Member Author

will try it again with this c498a75 on canary env

nope, still same

@preschian
* fix(index.ts): fix TypeError when modifying immutable headers
cf574b0 
* refactor(index.ts): add condition to modify headers only if not Apple device
@preschian
* fix(index.ts): remove conditional check for isApple and always set …
d238ea0 
…response headers

* chore(index.ts): remove TODO comment about TypeError
@vikiival
Copy link
Member

vikiival commented Oct 26, 2023 •
edited
Loading

Some quick reading:

@preschian preschian closed this Jan 12, 2024
@preschian preschian deleted the fix/add-accept-ranges branch January 12, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hassnian hassnian Awaiting requested review from hassnian hassnian will be requested when the pull request is marked ready for review hassnian is a code owner

@Jarsen136 Jarsen136 Awaiting requested review from Jarsen136 Jarsen136 will be requested when the pull request is marked ready for review Jarsen136 is a code owner

@vikiival vikiival Awaiting requested review from vikiival vikiival will be requested when the pull request is marked ready for review vikiival is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@preschian @vikiival