Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: opengraph images #308

Merged
merged 6 commits into from
Jun 20, 2024
Merged

fix: opengraph images #308

merged 6 commits into from
Jun 20, 2024

Conversation

preschian
Copy link
Member

@preschian preschian commented Jun 16, 2024

Context

Previously it fails render some images. This PR is to force "all" images by using smaller resolution

before: https://ogi.koda.art/ahp/gallery/127-2406146262/__og_image__/og.png
after: https://ogi-fix-opengraph-images.workers-ogi.pages.dev/__og-image__/image/ahp/gallery/127-2406146262/og.png

Ref

PR Type

  • Bugfix
  • Feature
  • Refactoring
  • Chore

Copy link

socket-security bot commented Jun 16, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/nuxt-og-image@3.0.0-rc.53 Transitive: environment, eval, filesystem, network, shell, unsafe +55 61.1 MB harlan_zw
npm/prettier@3.3.2 environment, filesystem, unsafe 0 8.25 MB prettier-bot
npm/remark-parse@11.0.0 None 0 19.5 kB wooorm
npm/remark-stringify@11.0.0 None 0 19.6 kB wooorm
npm/unified@11.0.4 None 0 147 kB wooorm
npm/vfile-matter@5.0.0 None 0 13.5 kB wooorm

🚮 Removed packages: npm/tslib@2.6.2

View full report↗︎

Copy link

socket-security bot commented Jun 16, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Install scripts npm/@fortawesome/free-regular-svg-icons@6.5.2
  • Install script: postinstall
  • Source: node attribution.js
  • orphan: npm/@fortawesome/free-regular-svg-icons@6.5.2
Install scripts npm/@fortawesome/free-solid-svg-icons@6.5.2
  • Install script: postinstall
  • Source: node attribution.js
  • orphan: npm/@fortawesome/free-solid-svg-icons@6.5.2
Install scripts npm/@fortawesome/fontawesome-common-types@6.5.2
  • Install script: postinstall
  • Source: node attribution.js
  • orphan: npm/@fortawesome/fontawesome-common-types@6.5.2
Install scripts npm/json-editor-vue@0.15.1
  • Install script: preinstall
  • Source: node -e "if (process.env.INIT_CWD === process.cwd()) { process.exit(1) }" || npx only-allow pnpm
Install scripts npm/json-editor-vue@0.15.1
  • Install script: postinstall
  • Source: node -e "if (process.env.INIT_CWD === process.cwd()) { process.exit(1) }" || npx simple-git-hooks
Install scripts npm/esbuild@0.21.5

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@fortawesome/free-regular-svg-icons@6.5.2
  • @SocketSecurity ignore npm/@fortawesome/free-solid-svg-icons@6.5.2
  • @SocketSecurity ignore npm/@fortawesome/fontawesome-common-types@6.5.2
  • @SocketSecurity ignore npm/json-editor-vue@0.15.1
  • @SocketSecurity ignore npm/esbuild@0.21.5

Copy link

cloudflare-workers-and-pages bot commented Jun 16, 2024

Deploying workers-ogi with  Cloudflare Pages  Cloudflare Pages

Latest commit: 492ab52
Status: ✅  Deploy successful!
Preview URL: https://49937f34.workers-ogi.pages.dev
Branch Preview URL: https://ogi-fix-opengraph-images.workers-ogi.pages.dev

View logs

@preschian preschian marked this pull request as ready for review June 16, 2024 10:23
@preschian preschian requested a review from a team as a code owner June 16, 2024 10:23
@preschian preschian requested review from yangwao, vikiival, Jarsen136 and hassnian and removed request for a team and yangwao June 16, 2024 10:23
@preschian preschian mentioned this pull request Jun 20, 2024
5 tasks
@preschian
Copy link
Member Author

merging this, and continue to #311

@preschian preschian merged commit 2fd6a8e into main Jun 20, 2024
3 of 4 checks passed
@preschian preschian deleted the ogi-fix-opengraph-images branch June 20, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant