Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ipos): filebase IPFS worker #316

Merged
merged 24 commits into from
Jul 17, 2024
Merged

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Jul 9, 2024

Context

add new ipos worker

envs

bucket: https://docs.filebase.com/getting-started/ipfs-getting-started-guide#how-to-create-an-ipfs-bucket
s3: https://docs.filebase.com/getting-started/s3-api-getting-started-guide#access-keys

 // S3
  S3_ACCESS_KEY_ID: string
  S3_SECRET_ACCESS_KEY: string //  secret env

  // Filebase
  FILEBASE_BUCKET_NAME: string 

Ref

PR Type

  • Bugfix
  • Feature
  • Refactoring
  • Chore

Screenshots

CleanShot 2024-07-17 at 13 48 09@2x

CleanShot 2024-07-17 at 13 48 35@2x

Copy link

socket-security bot commented Jul 9, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@cloudflare/workers-types@4.20240620.0 None 0 3.7 MB wrangler-publisher
npm/aws-sdk@2.1659.0 environment, filesystem, network, shell 0 97.2 MB aws-sdk-bot
npm/hono@4.4.12 None 0 897 kB yusukebe
npm/valibot@0.30.0 None 0 717 kB fabian-hiller

View full report↗︎

Copy link

socket-security bot commented Jul 10, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/aws-sdk@2.1659.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@hassnian
Copy link
Contributor Author

@vikiival
Copy link
Member

Hey,
Thanks for taking it.

We will use filebase.
I will make new issue for that

@vikiival vikiival closed this Jul 15, 2024
@vikiival vikiival reopened this Jul 15, 2024
ContentType: type,
})

await c.env.BUCKET.put(cid, new Blob([content], { type }))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use wait until so it's non blocking op

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@hassnian hassnian changed the title feat(ipos): R2(IPFS) worker feat(ipos): filebase IPFS worker Jul 17, 2024
@hassnian hassnian marked this pull request as ready for review July 17, 2024 08:42
@hassnian hassnian requested a review from Jarsen136 as a code owner July 17, 2024 08:42
@hassnian hassnian requested a review from preschian as a code owner July 17, 2024 08:42
@hassnian hassnian requested a review from vikiival July 17, 2024 08:42
@hassnian
Copy link
Contributor Author

hassnian commented Jul 17, 2024

@vikiival @preschian pls create a new worker called ipos and update wrangler.toml , so we can test this out

thanks

@vikiival
Copy link
Member

@SocketSecurity ignore aws-sdk@2.1659.0

@vikiival
Copy link
Member

Tested, works as charm

@vikiival
Copy link
Member

@SocketSecurity ignore npm/aws-sdk@2.1659.0

@vikiival vikiival merged commit 2fe1287 into kodadot:main Jul 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

R2(IPFS) worker
2 participants