func currentWeather is showing wrong version #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the book on chapter 12 the weather app is suppose to show the dummy data but the code provided in the start folder contains the final code with the api call. Shouldn't it be changed to the "dummy data" code that is mentioned at the start of the lesson?
gordonbeijing
approved these changes
May 18, 2022
|
Oh, nice catch! Looks good to me, what do you think @freak4pc ? |
freak4pc
approved these changes
May 18, 2022
| } | ||
| } | ||
| // Placeholder call | ||
| return Observable.just( |
There was a problem hiding this comment.
Good catch!
We can shorten this to one of these two variations:
Suggested change
| return Observable.just( | |
| Observable.just( |
Suggested change
| return Observable.just( | |
| .just( |
Besides, looks good. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the book on chapter 12 the weather app is suppose to show the dummy data but the code provided in the start folder contains the final code with the api call. Shouldn't it be changed to the "dummy data" code that is mentioned at the start of the lesson?