update env list filter logic #3230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: allenshen <shendongdong@koderover.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
🤖[deprecated] Generated by Copilot at c401d8b
Removed the
excludeSharedNSparameter from theListProductionEnvsAPI and added a newSharedNSfield to the response type. Moved the shared namespace logic from the handler to the service layer.What is changed and how it works?
🤖[deprecated] Generated by Copilot at c401d8b
excludeSharedNSparameter fromListProductionEnvsAPI and move the logic of determining shared namespace status to the service layer (link, link, link)SharedNSfield toEnvResptype to indicate whether the environment shares the same namespace with other environments in the same cluster (link)Does this PR introduce a user-facing change?