Skip to content

Add turkish #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
May 23, 2024
Merged

Add turkish #77

merged 20 commits into from
May 23, 2024

Conversation

koheiw
Copy link
Owner

@koheiw koheiw commented Apr 22, 2024

Add TR dictionary

@koheiw
Copy link
Owner Author

koheiw commented Apr 22, 2024

@LungtaSEKI, thanks for you PRs. I merged both and getting ready to release in a new version of the package.

It is failing the test because the dictionary does not match "Great Britain". Do you think you need to edit the dictionary?

> txt_tr <- c("Bu İrlanda hakkında bir makale.",
+             "Bu Büyük Britanya hakkında bir makale.")
> toks_tr <- tokens(txt_tr)
> tokens_lookup(toks_tr, data_dictionary_newsmap_tr, levels = 3)
Tokens consisting of 2 documents.
text1 :
[1] "IE"

text2 :
character(0)

@LungtaSEKI
Copy link
Collaborator

LungtaSEKI commented May 18, 2024

@koheiw My aplogies for getting back to you so late. I have just added Britanya and corrected other typos. I'd really appreciate it if you could check them.

@koheiw
Copy link
Owner Author

koheiw commented May 20, 2024

@LungtaSEKI Where can I find the updated file? It is easiest if you could edit file on this branch. You can clone this repository, and commit and push directly because you are a collaborator.

@koheiw koheiw merged commit f8e3003 into master May 23, 2024
@koheiw
Copy link
Owner Author

koheiw commented May 23, 2024

Done. Thanks @LungtaSEKI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants