Skip to content

Commit

Permalink
Drop rubocop-minitest from gem dependency
Browse files Browse the repository at this point in the history
Closes rails#13.

This PR drops rubocop-minitest from gem dependency.

In fact, the `Minitest` department's Cop is not used in rubocop-rails-omakase:
https://github.com/rails/rubocop-rails-omakase/blob/v1.0.0/rubocop.yml

This means that it might be appropriate for users to add the `Minitest` department's cop only when they start using it.
As a result, there will be no need to install gems that are not included in the rubocop-rails-omakase configuration.

Users can be given the choice to add cops based on the testing framework they are using.
  • Loading branch information
koic committed Jul 9, 2024
1 parent 1c1962b commit 9357aa5
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion rubocop-rails-omakase.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ Gem::Specification.new do |s|
s.add_dependency "rubocop"
s.add_dependency "rubocop-rails"
s.add_dependency "rubocop-performance"
s.add_dependency "rubocop-minitest"

s.files = %w[ rubocop.yml ]
end
1 change: 0 additions & 1 deletion rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
require:
- rubocop-performance
- rubocop-rails
- rubocop-minitest

inherit_mode:
merge:
Expand Down

0 comments on commit 9357aa5

Please sign in to comment.