Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Eigen CMake variable #48

Merged
merged 1 commit into from
May 8, 2024
Merged

Fix Eigen CMake variable #48

merged 1 commit into from
May 8, 2024

Conversation

valgur
Copy link
Contributor

@valgur valgur commented May 6, 2024

The upper-case EIGEN3_FOUND variable is available on v3.3.x, but has been removed in newer Eigen versions.

Since Eigen is always packaged with an Eigen3Config.cmake and CMake sets <PackageName>_FOUND automatically for CONFIG-type packages, Eigen3_FOUND should be used instead. From CMake docs:

A set of variables which provide package status information are also set automatically when using a config-file package. The <PackageName>_FOUND variable is set to true or false, depending on whether the package was found.

On an unrelated note - is there a reason why the automatically downloaded Eigen is v3.3.9 instead of v3.4.0?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.70%. Comparing base (3f61cb0) to head (db669ef).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   93.70%   93.70%           
=======================================
  Files          36       36           
  Lines         779      779           
  Branches       74       74           
=======================================
  Hits          730      730           
  Misses         49       49           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koide3
Copy link
Owner

koide3 commented May 8, 2024

Thanks a lot. I merge it now.

On an unrelated note - is there a reason why the automatically downloaded Eigen is v3.3.9 instead of v3.4.0?

I picked a random stable version I downloaded in the past for no reason, but I now think we should use the latest one. I'll update CMakeLists soon.

@koide3 koide3 merged commit 6e7b778 into koide3:master May 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants