Skip to content

Commit

Permalink
workflows: adding variable to set kokkos version to test against (#2389)
Browse files Browse the repository at this point in the history
* workflows: adding variable to set kokkos version to test against

The variable is set directly in at2.yml so it can be uniformly
applied to all the "sub-workflows" making maintenance when a
new release of kokkos comes out easier.

Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>

* workflow: fix for the osx builds

The new variable to set the version of Kokkos Core to build against
needs to use the "in script syntax" not the bash syntax.

Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>

---------

Signed-off-by: Luc Berger-Vergiat <lberge@sandia.gov>
  • Loading branch information
lucbv authored Oct 19, 2024
1 parent 8b318e6 commit 1974585
Show file tree
Hide file tree
Showing 7 changed files with 73 additions and 27 deletions.
15 changes: 14 additions & 1 deletion .github/workflows/at2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,27 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

env:
KOKKOS_VERSION: 4.4.01

jobs:
mi210:
uses: ./.github/workflows/mi210.yml
with:
kokkos_version: 4.4.01
h100:
uses: ./.github/workflows/h100.yml
with:
kokkos_version: 4.4.01
bdw:
uses: ./.github/workflows/bdw.yml
with:
kokkos_version: 4.4.01
spr:
uses: ./.github/workflows/spr.yml
with:
kokkos_version: 4.4.01
volta70:
uses: ./.github/workflows/volta70.yml
uses: ./.github/workflows/volta70.yml
with:
kokkos_version: 4.4.01
20 changes: 13 additions & 7 deletions .github/workflows/bdw.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
name: Reusable BDW workflow

on:
workflow_call

permissions:
contents: none

on:
workflow_call:
inputs:
kokkos_version:
description: 'The Kokkos Core version to build'
default: ''
required: true
type: string

jobs:
# PR_BDW_GNU1020_OPENMP_LEFT_REL_NOETI:
# name: PR_BDW_GNU1020_OPENMP_LEFT_REL_NOETI
Expand All @@ -21,7 +27,7 @@ jobs:
# uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
# with:
# repository: kokkos/kokkos
# ref: ${{ github.base_ref }}
# ref: ${{ inputs.kokkos_version }}
# path: kokkos
#
# - name: configure_kokkos
Expand Down Expand Up @@ -102,7 +108,7 @@ jobs:
# uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
# with:
# repository: kokkos/kokkos
# ref: ${{ github.base_ref }}
# ref: ${{ inputs.kokkos_version }}
# path: kokkos
#
# - name: configure_kokkos
Expand Down Expand Up @@ -184,7 +190,7 @@ jobs:
uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
with:
repository: kokkos/kokkos
ref: ${{ github.base_ref }}
ref: ${{ inputs.kokkos_version }}
path: kokkos

- name: configure_kokkos
Expand Down Expand Up @@ -269,7 +275,7 @@ jobs:
uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
with:
repository: kokkos/kokkos
ref: ${{ github.base_ref }}
ref: ${{ inputs.kokkos_version }}
path: kokkos

- name: configure_kokkos
Expand Down
14 changes: 10 additions & 4 deletions .github/workflows/h100.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
name: Reusable H100 workflow

on:
workflow_call

permissions:
contents: none

on:
workflow_call:
inputs:
kokkos_version:
description: 'The Kokkos Core version to build'
default: ''
required: true
type: string

jobs:
PR_HOPPER90_CUDA1180_CUDA_LEFT_RIGHT_REL:
name: PR_HOPPER90_CUDA1180_CUDA_LEFT_RIGHT_REL
Expand All @@ -21,7 +27,7 @@ jobs:
uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
with:
repository: kokkos/kokkos
ref: ${{ github.base_ref }}
ref: ${{ inputs.kokkos_version }}
path: kokkos

- name: configure_kokkos
Expand Down
16 changes: 11 additions & 5 deletions .github/workflows/mi210.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
name: Reusable MI210 workflow

on:
workflow_call

permissions:
contents: none

on:
workflow_call:
inputs:
kokkos_version:
description: 'The Kokkos Core version to build'
default: ''
required: true
type: string

jobs:
PR_VEGA90A_ROCM561_HIP_SERIAL_LEFT:
name: PR_VEGA90A_ROCM561_HIP_SERIAL_LEFT
Expand All @@ -21,7 +27,7 @@ jobs:
uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
with:
repository: kokkos/kokkos
ref: ${{ github.base_ref }}
ref: ${{ inputs.kokkos_version }}
path: kokkos

- name: configure_kokkos
Expand Down Expand Up @@ -102,7 +108,7 @@ jobs:
uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
with:
repository: kokkos/kokkos
ref: ${{ github.base_ref }}
ref: ${{ inputs.kokkos_version }}
path: kokkos

- name: configure_kokkos
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/osx.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

env:
kokkos_version: 4.4.01

jobs:
check-pr-labels:
runs-on: [ubuntu-latest]
Expand Down Expand Up @@ -58,7 +61,7 @@ jobs:
uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
with:
repository: kokkos/kokkos
ref: 4.3.01
ref: ${{ env.kokkos_version }}
path: kokkos

- name: configure_kokkos
Expand Down
14 changes: 10 additions & 4 deletions .github/workflows/spr.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
name: Reusable SPR workflow

on:
workflow_call

permissions:
contents: none

on:
workflow_call:
inputs:
kokkos_version:
description: 'The Kokkos Core version to build'
default: ''
required: true
type: string

jobs:
PR_SPR_ONEAPI202310_OPENMP_LEFT_MKLBLAS_MKLLAPACK_REL:
name: PR_SPR_ONEAPI202310_OPENMP_LEFT_MKLBLAS_MKLLAPACK_REL
Expand All @@ -21,7 +27,7 @@ jobs:
uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
with:
repository: kokkos/kokkos
ref: 4.3.01
ref: ${{ inputs.kokkos_version }}
path: kokkos

- name: configure
Expand Down
16 changes: 11 additions & 5 deletions .github/workflows/volta70.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
name: Reusable VOLTA70 workflow

on:
workflow_call

permissions:
contents: none

on:
workflow_call:
inputs:
kokkos_version:
description: 'The Kokkos Core version to build'
default: ''
required: true
type: string

jobs:
PR_VOLTA70_CUDA1122_CUDA_LEFT_RIGHT_REL:
name: PR_VOLTA70_CUDA1122_CUDA_LEFT_RIGHT_REL
Expand All @@ -21,7 +27,7 @@ jobs:
uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
with:
repository: kokkos/kokkos
ref: 4.4.00
ref: ${{ inputs.kokkos_version }}
path: kokkos

- name: configure_kokkos
Expand Down Expand Up @@ -87,7 +93,7 @@ jobs:
uses: actions/checkout@eef61447b9ff4aafe5dcd4e0bbf5d482be7e7871 # v4.2.1
with:
repository: kokkos/kokkos
ref: 4.4.00
ref: ${{ inputs.kokkos_version }}
path: kokkos

- name: configure_kokkos
Expand Down

0 comments on commit 1974585

Please sign in to comment.