Skip to content

Commit

Permalink
Disable empty return for _NVCOMPILER (#356)
Browse files Browse the repository at this point in the history
* disable empty return for _NVCOMPILER

* Fix MSVC CI build (drop unsupported argument passed to ctest)

```
Run ctest --output-on-failure --
CMake Error: Unknown argument: --
CMake Error: Run 'ctest --help' for all supported options.

---------

Co-authored-by: Damien L-G <dalg24+github@gmail.com>
  • Loading branch information
tcclevenger and dalg24 authored Aug 29, 2024
1 parent 98a12b0 commit c2494ad
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/cmake-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
- name: Test
working-directory: ${{github.workspace}}/mdspan-build
shell: bash
run: ctest --output-on-failure --
run: ctest --output-on-failure

- name: Install
shell: bash
Expand Down
8 changes: 4 additions & 4 deletions include/experimental/__p2642_bits/layout_padded.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ MDSPAN_INLINE_FUNCTION constexpr size_t get_actual_static_padding_value() {
return dynamic_extent;
}
// Missing return statement warning from NVCC and ICC
#if defined(__NVCC__) || defined(__INTEL_COMPILER)
#if (defined(__NVCC__) || defined(__INTEL_COMPILER)) && !defined(__NVCOMPILER)
return 0;
#endif
}
Expand Down Expand Up @@ -106,7 +106,7 @@ struct padded_extent {
return init_padding(exts, padding_value);
}
// Missing return statement warning from NVCC and ICC
#if defined(__NVCC__) || defined(__INTEL_COMPILER)
#if (defined(__NVCC__) || defined(__INTEL_COMPILER)) && !defined(__NVCOMPILER)
return {};
#endif
}
Expand All @@ -121,7 +121,7 @@ struct padded_extent {
return {};
}
// Missing return statement warning from NVCC and ICC
#if defined(__NVCC__) || defined(__INTEL_COMPILER)
#if (defined(__NVCC__) || defined(__INTEL_COMPILER)) && !defined(__NVCOMPILER)
return {};
#endif
}
Expand All @@ -136,7 +136,7 @@ struct padded_extent {
return {};
}
// Missing return statement warning from NVCC and ICC
#if defined(__NVCC__) || defined(__INTEL_COMPILER)
#if (defined(__NVCC__) || defined(__INTEL_COMPILER)) && !defined(__NVCOMPILER)
return {};
#endif
}
Expand Down

0 comments on commit c2494ad

Please sign in to comment.