Improve workaround clang bracket compilation bug #373
Merged
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we go again, this follows PR #364. I could still notice this issue by compiling with hipcc rocm
6.1.It appears that
6.1is based on clang17.0.0, see https://rocm.docs.amd.com/en/docs-6.2.0/compatibility/compatibility-matrix.html17.0.1and not17.0.0. I think it is the entry "Fix a crash when expanding a pack as the index of a subscript expression." in https://releases.llvm.org/17.0.1/tools/clang/docs/ReleaseNotes.html?1=#bug-fixes-to-c-support with the corresponding commit llvm/llvm-project@2528f1c#diff-3c28567b5e0c77d68f174541a0b77f5a85d093f58b89cd3675ee04a550a44880L4962With this fix, I could compile fine with hipcc rocm
6.1.