Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub CI: pin ubuntu-22.04 #377

Merged
merged 5 commits into from
Jan 20, 2025
Merged

GitHub CI: pin ubuntu-22.04 #377

merged 5 commits into from
Jan 20, 2025

Conversation

masterleinad
Copy link
Contributor

No description provided.

@nmm0
Copy link
Contributor

nmm0 commented Jan 16, 2025 •
edited
Loading

I guess we need to pin the OS version as ubuntu-latest is a moving target. What if we used some of the kokkos images?

@masterleinad masterleinad reopened this Jan 16, 2025
@masterleinad
Copy link
Contributor Author

I guess we need to pin the OS version as ubuntu-latest is a moving target. What if we used some of the kokkos images?

Looks like just pinning ubuntu-22.04 is sufficient for now and we could drop forcing-stdlib=libc++ and linking to libbenchmark1 (but I reverted those changes again).

@masterleinad masterleinad marked this pull request as ready for review January 16, 2025 19:55
@masterleinad masterleinad changed the title GitHub CI: drop libbenchmark1 GitHub CI: pin ubuntu-22.04 Jan 16, 2025
@nmm0 nmm0 merged commit 569a795 into kokkos:stable Jan 20, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmm0 nmm0 nmm0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masterleinad @nmm0