Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] dev from nf-core:dev #8

Open
wants to merge 1,711 commits into
base: dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1711 commits
Select commit Hold shift + click to select a range
d0a4bf2
back to original container
rannick Nov 13, 2023
b468942
revert to pandas
rannick Nov 13, 2023
960db4c
apply fixes
rannick Nov 14, 2023
3084301
Merge branch 'dev' into megafusion_to_vcf_collect
rannick Nov 15, 2023
852c6ac
compress vcf output
rannick Nov 15, 2023
7801cab
Merge branch 'megafusion_to_vcf_collect' of https://github.com/nf-cor…
rannick Nov 15, 2023
9643ed8
black
rannick Nov 15, 2023
bb703dd
modules updatge
rannick Nov 15, 2023
ef9f57a
move compression out of vcf_collect
rannick Nov 15, 2023
f33a5e9
fix ,/;
rannick Nov 15, 2023
a8b0743
fix values display vcf
rannick Nov 16, 2023
acf64a1
add hgnc id for fusionreport-only entries in vcf and add bug fix
rannick Nov 17, 2023
bc77e43
Merge branch 'dev' into update_doc
rannick Nov 17, 2023
152afdd
Merge pull request #414 from nf-core/megafusion_to_vcf_collect
rannick Nov 20, 2023
a881907
Merge branch 'dev' into update_doc
rannick Nov 20, 2023
1f872d4
add info on fusionreport scoring, genome supported, tool_cutoff and a…
rannick Nov 20, 2023
39273aa
Merge branch 'update_doc' of https://github.com/nf-core/rnafusion int…
rannick Nov 20, 2023
5fb4b57
improve documentation
rannick Nov 20, 2023
5389e76
prettier
rannick Nov 20, 2023
4a1a992
Update docs/usage.md
rannick Nov 20, 2023
7951b32
Merge pull request #437 from nf-core/update_doc
rannick Nov 20, 2023
9d7b98a
Fill non-empty values within each group for 'exon_number' and 'transc…
rannick Nov 20, 2023
6fe7cdd
remove max_sensitivity and max_mate_dist from fusioninspector filtering
rannick Nov 20, 2023
0b2e62a
add fastp output and fastqc after trim to multiqc
rannick Nov 20, 2023
311e1ab
fix multiqx
rannick Nov 22, 2023
de83a08
add files to multiqc
rannick Nov 22, 2023
45505e7
prettier
rannick Nov 22, 2023
3641a36
modules update + fix channel io
rannick Nov 22, 2023
4459e7c
fix typo
rannick Nov 22, 2023
5087346
fix
rannick Nov 22, 2023
3808fea
Merge branch 'dev' into fix_trim_multiqc
rannick Nov 22, 2023
ba1f4e2
fist steps
rannick Nov 22, 2023
bccdbc1
fix paths
rannick Nov 22, 2023
a0ea413
rename trimmed fastqc files
rannick Nov 22, 2023
8ed7167
add csv info from fusionreport csv in vcf_collect to insure position …
rannick Nov 24, 2023
e91639d
add channel i/o for new input fusionreport csv
rannick Nov 24, 2023
a568a9c
fusioninspector not sensititve
rannick Nov 24, 2023
15e4a54
fix channel io
rannick Nov 24, 2023
716a852
revert vcf
rannick Nov 24, 2023
a76b162
revert fusioninspector filtering
rannick Nov 24, 2023
04d57f0
Update assets/multiqc_config.yml
rannick Nov 24, 2023
3fd0289
Update assets/multiqc_config.yml
rannick Nov 24, 2023
113dd9e
udpate changelog
rannick Nov 24, 2023
652cbd7
add conditions for collectinsertsize running
rannick Nov 24, 2023
dead314
update changelog
rannick Nov 24, 2023
2e4a8ce
Merge pull request #444 from nf-core/fix_collectinsertsize
rannick Nov 24, 2023
2cb7fc5
Merge branch 'dev' into fix_trim_multiqc
rannick Nov 24, 2023
8f0acc0
Merge branch 'dev' into add_positions_vcf
rannick Nov 24, 2023
ba679fb
Merge pull request #440 from nf-core/fix_trim_multiqc
rannick Nov 24, 2023
635bee6
update fusionreport
rannick Nov 24, 2023
6007ea1
Merge branch 'dev' into update-fusionreport-no-fusiondgb
rannick Nov 24, 2023
74f2f1a
Merge pull request #445 from nf-core/update-fusionreport-no-fusiondgb
rannick Nov 24, 2023
4a216e7
update changelog
rannick Nov 24, 2023
323cf52
Merge branch 'add_positions_vcf' of https://github.com/nf-core/rnafus…
rannick Nov 24, 2023
f5cc4a7
Merge branch 'dev' into add_positions_vcf
rannick Nov 24, 2023
4596849
update doc
rannick Nov 24, 2023
a429ca8
update changelof
rannick Nov 24, 2023
1ec2a29
merge
rannick Nov 24, 2023
d1bc30d
Merge pull request #443 from nf-core/add_positions_vcf
rannick Nov 24, 2023
ef99ba4
Merge pull request #446 from nf-core/update_weight_doc
rannick Nov 24, 2023
df7a7b3
Update CHANGELOG.md
rannick Nov 27, 2023
c4526a9
Update tower.yml
rannick Nov 27, 2023
cbf73a1
bump version and remove igenomes param
rannick Nov 27, 2023
bd82e62
Merge branch 'dev' of https://github.com/nf-core/rnafusion into dev
rannick Nov 27, 2023
89075bb
update modules
rannick Nov 27, 2023
4ae96ff
clarify changelog
rannick Nov 27, 2023
f5ecf8d
Merge pull request #447 from nf-core/dev
rannick Nov 27, 2023
3328c76
update version to 4.0.0
rannick Nov 27, 2023
279daf4
prepare changelog for 4.0.0
rannick Nov 27, 2023
bb271bb
fix versions
rannick Nov 29, 2023
d264cea
update changelog
rannick Nov 29, 2023
226b24a
update version to 3.0.1
rannick Nov 29, 2023
35cb3fe
-
rannick Nov 29, 2023
754d7c6
Merge pull request #451 from nf-core/fix_versions
rannick Nov 29, 2023
1c86d07
Merge branch 'dev' into python3
rannick Nov 29, 2023
456d612
Merge pull request #452 from nf-core/python3
rannick Nov 29, 2023
0d189d2
Merge branch 'master' into dev
rannick Nov 29, 2023
98f02be
Merge pull request #453 from nf-core/dev
fevac Nov 29, 2023
f5a1c41
fix vcf_collect when a tool is absent
rannick Dec 19, 2023
266f007
Template update for nf-core/tools version 2.11
nf-core-bot Dec 19, 2023
cfb0833
Template update for nf-core/tools version 2.11.1
nf-core-bot Dec 20, 2023
683538f
Merge branch 'dev' into nf-core-template-merge-2.11.1
rannick Dec 20, 2023
0ccea2e
Revert "fix vcf_collect when a tool is absent"
rannick Dec 20, 2023
d76dfc4
fix vcf_collect when a tool is absent
rannick Dec 20, 2023
b7b8c66
Merge branch 'dev' into nf-core-template-merge-2.11.1
rannick Dec 20, 2023
d163a4a
fix version issue
rannick Dec 20, 2023
81ded81
Merge pull request #457 from nf-core/nf-core-template-merge-2.11.1
rannick Jan 29, 2024
e996b93
Merge branch 'dev' into absent_tools
rannick Jan 29, 2024
81ca0c0
prettier
rannick Jan 29, 2024
d0f345a
Template update for nf-core/tools version 2.12
nf-core-bot Jan 29, 2024
887624c
update changelog
rannick Jan 31, 2024
ffe9c09
Merge pull request #458 from nf-core/absent_tools
rannick Jan 31, 2024
901fa94
add dump and rewrite channel
rannick Feb 2, 2024
c37fe98
fix vcf_collect when fusioninspector output is empty but fusionreport…
rannick Feb 2, 2024
a6659da
update changelog
rannick Feb 2, 2024
b67a751
update changelog
rannick Feb 2, 2024
2dae239
Merge branch 'dev' into nf-core-template-merge-2.12
rannick Feb 2, 2024
26e492c
black
rannick Feb 2, 2024
b2db95e
harmonise ensembl_version default to 102
rannick Feb 2, 2024
30604e2
prettier
rannick Feb 2, 2024
8c243b3
prettier with correct version
rannick Feb 2, 2024
239345a
fix logos
rannick Feb 2, 2024
49b2fb4
fix editorconfig
rannick Feb 2, 2024
bc0e366
update logos from TEMPLATES
rannick Feb 2, 2024
d514957
Merge pull request #464 from nf-core/nf-core-template-merge-2.12
rannick Feb 3, 2024
6f7d915
Merge branch 'dev' into fix_whitelist
rannick Feb 3, 2024
017d6da
Merge branch 'dev' into fix_vcf
rannick Feb 5, 2024
066993e
update changelog
rannick Feb 5, 2024
8440a2c
Merge pull request #465 from nf-core/fix_vcf
rannick Feb 5, 2024
2988e8f
Merge branch 'dev' into fix_whitelist
rannick Feb 5, 2024
abcc7a8
Merge pull request #466 from nf-core/fix_whitelist
rannick Feb 5, 2024
2c75e60
Template update for nf-core/tools version 2.13
nf-core-bot Feb 20, 2024
05ffaee
Template update for nf-core/tools version 2.13.1
nf-core-bot Feb 29, 2024
ec3e795
update collectrnaseqmetrics memory requirement
rannick Mar 4, 2024
0980e9f
update changelog
rannick Mar 4, 2024
2cea1a4
first step fix
rannick Mar 4, 2024
840c0f2
pre-commit for template merge 2.13.1
rannick Mar 4, 2024
3e8a300
first changes
rannick Mar 4, 2024
65b510b
merging
rannick Mar 4, 2024
ef0ac08
remove genome arg
rannick Mar 4, 2024
7f37d02
move fasta out from genome
rannick Mar 4, 2024
49d4eca
merge fixes
rannick Mar 4, 2024
b64f5ae
merge fixes
rannick Mar 4, 2024
296bb48
genomes
rannick Mar 4, 2024
f551306
add genome
rannick Mar 4, 2024
38fe79f
fix merging
rannick Mar 4, 2024
3a9e123
fix merging
rannick Mar 4, 2024
22e3ecb
checks
rannick Mar 4, 2024
dae6bd1
remove commented out param checks, moved to issue
rannick Mar 6, 2024
bddbb71
add strandedness in input schema
rannick Mar 8, 2024
2c1f1e5
update instructions to run nf-test
rannick Mar 8, 2024
255d91c
writh pipeline test
rannick Mar 8, 2024
ffed4c0
write general test config
rannick Mar 8, 2024
645634c
comment out nf-test from PR template
rannick Mar 8, 2024
6a31fd0
CONTRIBUTING AND PULL_REQUEST_TEMPLATE not part of files_unchanged
rannick Mar 8, 2024
27ae59d
prettier
rannick Mar 8, 2024
c4fb47d
remove tests
rannick Mar 8, 2024
9313a47
fix ci
rannick Mar 15, 2024
1ea6a3a
add //
rannick Mar 15, 2024
6e24086
checkMaxContigSize function
rannick Mar 15, 2024
05e647d
Merge pull request #473 from nf-core/nf-core-template-merge-2.13.1
rannick Mar 15, 2024
a66ec84
bugfix for vcf
rannick Mar 18, 2024
5858c3c
Merge pull request #480 from nf-core/merging_2.13.1
rannick Mar 18, 2024
fa9e830
Merge branch 'dev' into vcf_fix2
rannick Mar 18, 2024
3ec3090
black without line limit
rannick Mar 18, 2024
2660469
Merge branch 'vcf_fix2' of https://github.com/nf-core/rnafusion into …
rannick Mar 19, 2024
2b6ff48
update changelog
rannick Mar 19, 2024
fe3de40
Merge pull request #481 from nf-core/vcf_fix2
rannick Mar 25, 2024
8f02765
merging
rannick Mar 25, 2024
78a56b3
align {
rannick Apr 3, 2024
2448d7f
Merge branch 'fix_rnaseqmetrics_mem' of https://github.com/nf-core/rn…
rannick Apr 3, 2024
3ab9344
fix logical gate: when stringtie and not starfusion, only alignment i…
rannick Apr 3, 2024
6a36c3e
fix conda package requirements
rannick Apr 3, 2024
4fe1a5d
Merge pull request #474 from nf-core/fix_rnaseqmetrics_mem
rannick Apr 3, 2024
d506c69
update changelog
rannick Apr 3, 2024
88a3540
Merge branch 'dev' into fix_stringtie_log_gate
rannick Apr 3, 2024
e50eed2
Merge pull request #482 from nf-core/fix_stringtie_log_gate
rannick Apr 3, 2024
e3a909f
bump version 3.0.2
rannick Apr 3, 2024
86375ae
Merge branch 'master' into dev
rannick Apr 3, 2024
2dbd134
update changelog date
rannick Apr 3, 2024
1f51050
Merge branch 'dev' of https://github.com/nf-core/rnafusion into dev
rannick Apr 3, 2024
58dd112
remove emtpy file
rannick Apr 8, 2024
a5428bf
Update nextflow.config
rannick Apr 8, 2024
3602cc0
remove nf-test.log
rannick Apr 8, 2024
5adb521
Update workflows/rnafusion.nf
rannick Apr 8, 2024
d09c5bb
use a real input as validation of the samplesheet occurs even with bu…
rannick Apr 8, 2024
f18fab7
Merge branch 'dev' of https://github.com/nf-core/rnafusion into dev
rannick Apr 8, 2024
c27117b
final release date in changelog
rannick Apr 10, 2024
42eb8d6
Merge pull request #483 from nf-core/dev
rannick Apr 10, 2024
7deb242
bump version to 4.0.0dev
rannick Apr 10, 2024
8f794b3
get arriba from nf-core
rannick Apr 10, 2024
2133827
fix path
rannick Apr 10, 2024
a8f87e7
add latest zenodo
rannick Apr 10, 2024
6c0645a
remove TODOs
rannick Apr 10, 2024
0443c44
update starfusion
rannick Apr 10, 2024
2c35b26
picard collectrnaseqmetrics to nf-core
rannick Apr 12, 2024
20b8b1b
fix channels
rannick Apr 12, 2024
ba4396b
use ucsc gtftogenepred from nf-core
rannick Apr 12, 2024
91a2af2
bedops convert2bed from nf-core
rannick Apr 16, 2024
b493b90
Template update for nf-core/tools version 2.14.0
nf-core-bot May 8, 2024
aeca9e2
Template update for nf-core/tools version 2.14.1
nf-core-bot May 9, 2024
2da7590
add salmon first steps
rannick May 14, 2024
65485bc
merge template
rannick May 14, 2024
89ade66
remove samplesheet check conf
rannick May 14, 2024
14b2dc8
Merge pull request #486 from nf-core/nf-core-template-merge-2.14.1
rannick May 17, 2024
7e0b3b1
Merge branch 'dev' into update_modules
rannick May 17, 2024
71f8caf
tests
rannick May 21, 2024
973ee3b
Merge branch 'dev' into add_normalized_gene_expression
rannick May 21, 2024
0a87206
update
rannick May 21, 2024
c106e48
fix merge conflicts
rannick May 21, 2024
3be24cb
fix merge conflicts
rannick May 21, 2024
002b928
cleanup
rannick May 21, 2024
0999af2
cleanup
rannick May 21, 2024
3f47ecd
remove local gffread
rannick May 21, 2024
7f1065a
use primary assembly as main fasta and gtf instead of chr
rannick May 21, 2024
e98df82
fix channel io
rannick May 21, 2024
8b59963
update changelog and output
rannick May 21, 2024
83e820a
Update conf/modules.config
rannick May 22, 2024
7a2aca5
update modules and use rrnatranscript from nf-core
rannick May 22, 2024
c8b3309
fix channel io
rannick May 22, 2024
eeeb9ae
remove gunzip
rannick May 22, 2024
6d08a74
prettier
rannick May 22, 2024
09e2aba
Merge pull request #488 from nf-core/add_normalized_gene_expression
rannick May 23, 2024
49c1337
update docs
asp8200 Jun 11, 2024
5be23db
update changelog
asp8200 Jun 11, 2024
5f3b5f7
Merge pull request #491 from nf-core/fix_docs
maxulysse Jun 11, 2024
0b854c6
Add option to wget to ignore proxy certificates
apeltzer Aug 8, 2024
8f8eeaa
Add changelog
apeltzer Aug 8, 2024
d1b833b
Merge branch 'dev' into fix-wget-proxy
apeltzer Aug 8, 2024
ed6c8c7
Merge pull request #496 from nf-core/fix-wget-proxy
apeltzer Aug 8, 2024
8e55ba4
fix merge commits
rannick Sep 12, 2024
40da42d
update modules again
rannick Sep 12, 2024
5f0f4de
Merge branch 'dev' of https://github.com/nf-core/rnafusion into updat…
rannick Sep 12, 2024
55dcc55
update arriba modules
rannick Sep 12, 2024
f9f808d
rm file
rannick Sep 12, 2024
7f8ee68
fixes
rannick Sep 12, 2024
e54c5a6
remove files
rannick Sep 12, 2024
26d44e4
update new fastq arg
rannick Sep 17, 2024
9a4a8eb
update multiqc and multiqc args
rannick Sep 18, 2024
e5ffe10
update
rannick Oct 7, 2024
db7cf55
updated changelog
rannick Oct 8, 2024
b8c672a
Template update for nf-core/tools version 3.0.0
nf-core-bot Oct 8, 2024
3dcb058
Template update for nf-core/tools version 3.0.1
nf-core-bot Oct 9, 2024
fce681c
Merge pull request #484 from nf-core/update_modules
rannick Oct 9, 2024
5073208
remove fusiongdb
rannick Oct 10, 2024
3de8b31
update changelog
rannick Oct 10, 2024
2c08d0c
remove fusiongdb
rannick Oct 10, 2024
fedf17f
Template update for nf-core/tools version 3.0.2
nf-core-bot Oct 11, 2024
d3752b2
Merge branch 'dev' into nf-core-template-merge-3.0.2
rannick Oct 16, 2024
d6ca5b5
prettier
rannick Oct 16, 2024
e918b82
linitng
rannick Oct 16, 2024
90fab19
fix input checks
rannick Oct 16, 2024
82da729
add igenomes to linting exclusion
rannick Oct 16, 2024
4b93703
remove exist false for input as logic changed
rannick Oct 16, 2024
046c74d
declare samplesheet as input
rannick Oct 16, 2024
e8949e0
adapt samplesheet
rannick Oct 16, 2024
94fb246
change output dir to avoid overwriting
rannick Oct 17, 2024
4e029f8
correct error in output of version in hgcn
rannick Oct 17, 2024
8d7f7a9
revert change of dir
rannick Oct 17, 2024
33e394c
correct for ensembl too
rannick Oct 17, 2024
93254d2
remove check max
rannick Oct 17, 2024
533a7da
remove duplicate profile
rannick Oct 17, 2024
b3a67f5
backtrack rnafusion main
rannick Oct 17, 2024
6773f5b
update containers to nf-core and quay registry
rannick Oct 17, 2024
1d63040
remove quay but leave the docker.io repo
rannick Oct 17, 2024
898306e
add files to multiqc
rannick Oct 17, 2024
b1891c5
update changelog
rannick Oct 17, 2024
5b25284
Merge pull request #504 from nf-core/nf-core-template-merge-3.0.2
rannick Oct 17, 2024
68ccba0
Merge branch 'dev' into rm_fusiongdb_from_doc
rannick Oct 17, 2024
22d0e80
Merge pull request #503 from nf-core/rm_fusiongdb_from_doc
rannick Oct 17, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
20 changes: 20 additions & 0 deletions .devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{
"name": "nfcore",
"image": "nfcore/gitpod:latest",
"remoteUser": "gitpod",
"runArgs": ["--privileged"],

// Configure tool-specific properties.
"customizations": {
// Configure properties specific to VS Code.
"vscode": {
// Set *default* container specific settings.json values on container create.
"settings": {
"python.defaultInterpreterPath": "/opt/conda/bin/python"
},

// Add the IDs of extensions you want installed when the container is created.
"extensions": ["ms-python.python", "ms-python.vscode-pylance", "nf-core.nf-core-extensionpack"]
}
}
}
33 changes: 33 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
root = true

[*]
charset = utf-8
end_of_line = lf
insert_final_newline = true
trim_trailing_whitespace = true
indent_size = 4
indent_style = space

[*.{md,yml,yaml,html,css,scss,js}]
indent_size = 2

# These files are edited and tested upstream in nf-core/modules
[/modules/nf-core/**]
charset = unset
end_of_line = unset
insert_final_newline = unset
trim_trailing_whitespace = unset
indent_style = unset
[/subworkflows/nf-core/**]
charset = unset
end_of_line = unset
insert_final_newline = unset
trim_trailing_whitespace = unset
indent_style = unset

[/assets/email*]
indent_size = unset

# ignore python and markdown
[*.{py,md}]
indent_style = unset
3 changes: 3 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
*.config linguist-language=nextflow
*.nf.test linguist-language=nextflow
modules/nf-core/** linguist-generated
subworkflows/nf-core/** linguist-generated
6 changes: 6 additions & 0 deletions .github/.dockstore.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Dockstore config version, not pipeline version
version: 1.2
workflows:
- subclass: nfl
primaryDescriptorPath: /nextflow.config
publish: True
128 changes: 103 additions & 25 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,47 +1,125 @@
# nf-core/rnafusion: Contributing Guidelines

Hi there! Many thanks for taking an interest in improving nf-core/rnafusion.
Hi there!
Many thanks for taking an interest in improving nf-core/rnafusion.

We try to manage the required tasks for nf-core/rnafusion using GitHub issues, you probably came to this page when creating one. Please use the pre-filled template to save time.

However, don't be put off by this template - other more general issues and suggestions are welcome! Contributions to the code are even more welcome ;)

> If you need help using or modifying nf-core/rnafusion then the best place to ask is on the pipeline channel on [Slack](https://nf-core-invite.herokuapp.com/).
We try to manage the required tasks for nf-core/rnafusion using GitHub issues, you probably came to this page when creating one.
Please use the pre-filled template to save time.

However, don't be put off by this template - other more general issues and suggestions are welcome!
Contributions to the code are even more welcome ;)

> [!NOTE]
> If you need help using or modifying nf-core/rnafusion then the best place to ask is on the nf-core Slack [#rnafusion](https://nfcore.slack.com/channels/rnafusion) channel ([join our Slack here](https://nf-co.re/join/slack)).

## Contribution workflow
If you'd like to write some code for nf-core/rnafusion, the standard workflow
is as follows:

1. Check that there isn't already an issue about your idea in the
[nf-core/rnafusion issues](https://github.com/nf-core/rnafusion/issues) to avoid
duplicating work.
* If there isn't one already, please create one so that others know you're working on this
2. Fork the [nf-core/rnafusion repository](https://github.com/nf-core/rnafusion) to your GitHub account
3. Make the necessary changes / additions within your forked repository
4. Submit a Pull Request against the `dev` branch and wait for the code to be reviewed and merged.
If you'd like to write some code for nf-core/rnafusion, the standard workflow is as follows:

If you're not used to this workflow with git, you can start with some [basic docs from GitHub](https://help.github.com/articles/fork-a-repo/) or even their [excellent interactive tutorial](https://try.github.io/).
1. Check that there isn't already an issue about your idea in the [nf-core/rnafusion issues](https://github.com/nf-core/rnafusion/issues) to avoid duplicating work. If there isn't one already, please create one so that others know you're working on this
2. [Fork](https://help.github.com/en/github/getting-started-with-github/fork-a-repo) the [nf-core/rnafusion repository](https://github.com/nf-core/rnafusion) to your GitHub account
3. Make the necessary changes / additions within your forked repository following [Pipeline conventions](#pipeline-contribution-conventions)
4. Use `nf-core pipelines schema build` and add any new parameters to the pipeline JSON schema (requires [nf-core tools](https://github.com/nf-core/tools) >= 1.10).
5. Submit a Pull Request against the `dev` branch and wait for the code to be reviewed and merged

If you're not used to this workflow with git, you can start with some [docs from GitHub](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests) or even their [excellent `git` resources](https://try.github.io/).

## Tests
When you create a pull request with changes, [Travis CI](https://travis-ci.org/) will run automatic tests.

You have the option to test your changes locally by running the pipeline. For receiving warnings about process selectors and other `debug` information, it is recommended to use the debug profile. Execute all the tests with the following command, BUT DON'T FORGET TO ADD THE PARAMETERS cosmic_username AND cosmic_passwd in tests/main.nf.test.

```bash
nf-test test --profile debug,test,docker --verbose
```

When you create a pull request with changes, [GitHub Actions](https://github.com/features/actions) will run automatic tests.
Typically, pull-requests are only fully reviewed when these tests are passing, though of course we can help out before then.

There are typically two types of tests that run:

### Lint Tests
The nf-core has a [set of guidelines](http://nf-co.re/guidelines) which all pipelines must adhere to.
To enforce these and ensure that all pipelines stay in sync, we have developed a helper tool which runs checks on the pipeline code. This is in the [nf-core/tools repository](https://github.com/nf-core/tools) and once installed can be run locally with the `nf-core lint <pipeline-directory>` command.
### Lint tests

`nf-core` has a [set of guidelines](https://nf-co.re/developers/guidelines) which all pipelines must adhere to.
To enforce these and ensure that all pipelines stay in sync, we have developed a helper tool which runs checks on the pipeline code. This is in the [nf-core/tools repository](https://github.com/nf-core/tools) and once installed can be run locally with the `nf-core pipelines lint <pipeline-directory>` command.

If any failures or warnings are encountered, please follow the listed URL for more documentation.

### Pipeline Tests
Each nf-core pipeline should be set up with a minimal set of test-data.
Travis CI then runs the pipeline on this data to ensure that it exists successfully.
### Pipeline tests

Each `nf-core` pipeline should be set up with a minimal set of test-data.
`GitHub Actions` then runs the pipeline on this data to ensure that it exits successfully.
If there are any failures then the automated tests fail.
These tests are run both with the latest available version of Nextflow and also the minimum required version that is stated in the pipeline code.
These tests are run both with the latest available version of `Nextflow` and also the minimum required version that is stated in the pipeline code.

## Patch

:warning: Only in the unlikely and regretful event of a release happening with a bug.

- On your own fork, make a new branch `patch` based on `upstream/master`.
- Fix the bug, and bump version (X.Y.Z+1).
- A PR should be made on `master` from patch to directly this particular bug.

## Getting help
For further information/help, please consult the [nf-core/rnafusion documentation](https://github.com/nf-core/rnafusion#documentation) and don't hesitate to get in touch on the pipeline channel on [Slack](https://nf-core-invite.herokuapp.com/).

For further information/help, please consult the [nf-core/rnafusion documentation](https://nf-co.re/rnafusion/usage) and don't hesitate to get in touch on the nf-core Slack [#rnafusion](https://nfcore.slack.com/channels/rnafusion) channel ([join our Slack here](https://nf-co.re/join/slack)).

## Pipeline contribution conventions

To make the nf-core/rnafusion code and processing logic more understandable for new contributors and to ensure quality, we semi-standardise the way the code and other contributions are written.

### Adding a new step

If you wish to contribute a new step, please use the following coding standards:

1. Define the corresponding input channel into your new process from the expected previous process channel
2. Write the process block (see below).
3. Define the output channel if needed (see below).
4. Add any new parameters to `nextflow.config` with a default (see below).
5. Add any new parameters to `nextflow_schema.json` with help text (via the `nf-core pipelines schema build` tool).
6. Add sanity checks and validation for all relevant parameters.
7. Perform local tests to validate that the new code works as expected.
8. If applicable, add a new test command in `.github/workflow/ci.yml`.
9. Update MultiQC config `assets/multiqc_config.yml` so relevant suffixes, file name clean up and module plots are in the appropriate order. If applicable, add a [MultiQC](https://https://multiqc.info/) module.
10. Add a description of the output files and if relevant any appropriate images from the MultiQC report to `docs/output.md`.

### Default values

Parameters should be initialised / defined with default values in `nextflow.config` under the `params` scope.

Once there, use `nf-core pipelines schema build` to add to `nextflow_schema.json`.

### Default processes resource requirements

Sensible defaults for process resource requirements (CPUs / memory / time) for a process should be defined in `conf/base.config`. These should generally be specified generic with `withLabel:` selectors so they can be shared across multiple processes/steps of the pipeline. A nf-core standard set of labels that should be followed where possible can be seen in the [nf-core pipeline template](https://github.com/nf-core/tools/blob/main/nf_core/pipeline-template/conf/base.config), which has the default process as a single core-process, and then different levels of multi-core configurations for increasingly large memory requirements defined with standardised labels.

The process resources can be passed on to the tool dynamically within the process with the `${task.cpus}` and `${task.memory}` variables in the `script:` block.

### Naming schemes

Please use the following naming schemes, to make it easy to understand what is going where.

- initial process channel: `ch_output_from_<process>`
- intermediate and terminal channels: `ch_<previousprocess>_for_<nextprocess>`

### Nextflow version bumping

If you are using a new feature from core Nextflow, you may bump the minimum required version of nextflow in the pipeline with: `nf-core pipelines bump-version --nextflow . [min-nf-version]`

### Images and figures

For overview images and other documents we follow the nf-core [style guidelines and examples](https://nf-co.re/developers/design_guidelines).

## GitHub Codespaces

This repo includes a devcontainer configuration which will create a GitHub Codespaces for Nextflow development! This is an online developer environment that runs in your browser, complete with VSCode and a terminal.

To get started:

- Open the repo in [Codespaces](https://github.com/nf-core/rnafusion/codespaces)
- Tools installed
- nf-core
- Nextflow

Devcontainer specs:

- [DevContainer config](.devcontainer/devcontainer.json)
31 changes: 0 additions & 31 deletions .github/ISSUE_TEMPLATE/bug_report.md

This file was deleted.

50 changes: 50 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
name: Bug report
description: Report something that is broken or incorrect
labels: bug
body:
- type: markdown
attributes:
value: |
Before you post this issue, please check the documentation:

- [nf-core website: troubleshooting](https://nf-co.re/usage/troubleshooting)
- [nf-core/rnafusion pipeline documentation](https://nf-co.re/rnafusion/usage)

- type: textarea
id: description
attributes:
label: Description of the bug
description: A clear and concise description of what the bug is.
validations:
required: true

- type: textarea
id: command_used
attributes:
label: Command used and terminal output
description: Steps to reproduce the behaviour. Please paste the command you used to launch the pipeline and the output from your terminal.
render: console
placeholder: |
$ nextflow run ...

Some output where something broke

- type: textarea
id: files
attributes:
label: Relevant files
description: |
Please drag and drop the relevant files here. Create a `.zip` archive if the extension is not allowed.
Your verbose log file `.nextflow.log` is often useful _(this is a hidden file in the directory where you launched the pipeline)_ as well as custom Nextflow configuration files.

- type: textarea
id: system
attributes:
label: System information
description: |
* Nextflow version _(eg. 23.04.0)_
* Hardware _(eg. HPC, Desktop, Cloud)_
* Executor _(eg. slurm, local, awsbatch)_
* Container engine: _(e.g. Docker, Singularity, Conda, Podman, Shifter, Charliecloud, or Apptainer)_
* OS _(eg. CentOS Linux, macOS, Linux Mint)_
* Version of nf-core/rnafusion _(eg. 1.1, 1.5, 1.8.2)_
7 changes: 7 additions & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
contact_links:
- name: Join nf-core
url: https://nf-co.re/join
about: Please join the nf-core community here
- name: "Slack #rnafusion channel"
url: https://nfcore.slack.com/channels/rnafusion
about: Discussion about the nf-core/rnafusion pipeline
16 changes: 0 additions & 16 deletions .github/ISSUE_TEMPLATE/feature_request.md

This file was deleted.

11 changes: 11 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
name: Feature request
description: Suggest an idea for the nf-core/rnafusion pipeline
labels: enhancement
body:
- type: textarea
id: description
attributes:
label: Description of feature
description: Please describe your suggestion for a new feature. It might help to describe a problem or use case, plus any alternatives that you have considered.
validations:
required: true
35 changes: 23 additions & 12 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,26 @@
Many thanks to contributing to nf-core/rnafusion!
<!--
# nf-core/rnafusion pull request

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).
Many thanks for contributing to nf-core/rnafusion!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

Remember that PRs should be made against the dev branch, unless you're preparing a pipeline release.

Learn more about contributing: [CONTRIBUTING.md](https://github.com/nf-core/rnafusion/tree/master/.github/CONTRIBUTING.md)
-->

## PR checklist
- [ ] This comment contains a description of changes (with reason)
- [ ] If you've fixed a bug or added code that should be tested, add tests!
- [ ] If necessary, also make a PR on the [nf-core/rnafusion branch on the nf-core/test-datasets repo]( https://github.com/nf-core/test-datasets/pull/new/nf-core/rnafusion)
- [ ] Ensure the test suite passes (`nextflow run . -profile test,docker`).
- [ ] Make sure your code lints (`nf-core lint .`).
- [ ] Documentation in `docs` is updated
- [ ] `CHANGELOG.md` is updated
- [ ] `README.md` is updated

**Learn more about contributing:** https://github.com/nf-core/rnafusion/tree/master/.github/CONTRIBUTING.md

- [ ] This comment contains a description of changes (with reason).
- [ ] If you've fixed a bug or added code that should be tested, add tests!
- [ ] If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/rnafusion/tree/master/.github/CONTRIBUTING.md)
- [ ] If necessary, also make a PR on the nf-core/rnafusion _branch_ on the [nf-core/test-datasets](https://github.com/nf-core/test-datasets) repository.
- [ ] Make sure your code lints (`nf-core pipelines lint`).
- [ ] Ensure the test suite passes (`nextflow run . -profile test,docker --outdir <OUTDIR>`).
- [ ] Check for unexpected warnings in debug mode (`nextflow run . -profile debug,test,docker --outdir <OUTDIR>`).
- [ ] Usage Documentation in `docs/usage.md` is updated.
- [ ] Output Documentation in `docs/output.md` is updated.
- [ ] `CHANGELOG.md` is updated.
- [ ] `README.md` is updated (including new tool citations and authors/contributors).
9 changes: 0 additions & 9 deletions .github/markdownlint.yml

This file was deleted.

Loading