Skip to content

Commit

Permalink
Add documentation, comment out unused func
Browse files Browse the repository at this point in the history
  • Loading branch information
RebeccaMahany committed Sep 23, 2024
1 parent c6ad847 commit 109d1ed
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion ee/presencedetection/presencedetection_windows.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ type KeyCredentialVTable struct {
GetAttestationAsync uintptr
}

// KeyCredentialAttestationResult is defined here:
// https://learn.microsoft.com/en-us/uwp/api/windows.security.credentials.keycredentialattestationresult?view=winrt-26100
type KeyCredentialAttestationResult struct {
ole.IInspectable
}
Expand Down Expand Up @@ -303,7 +305,6 @@ func requestCreate(keyCredentialManager *KeyCredentialManager, credentialName st
}

return pubkeyBytes, keyCredentialObj, nil

}

// getAttestationAsync calls Windows.Security.Credentials.KeyCredential.GetAttestationAsync.
Expand Down Expand Up @@ -392,6 +393,7 @@ func getAttestationAsync(credential *KeyCredential) ([]byte, error) {
return attestationBytes, nil
}

/*
// waitForAsyncOperation should allow us to abstract away the details of waiting for an async operation,
// but right now it only works for IsSupportedAsync; it results in an error 3 being returned from RequestCreateAsync.
// TODO RM -- fix.
Expand All @@ -417,3 +419,4 @@ func waitForAsyncOperation(signature string, timeout time.Duration, asyncOperati
return asyncOperation.GetResults()
}
*/

0 comments on commit 109d1ed

Please sign in to comment.