checkpoint

pkg/osquery/runsimple/osqueryrunner.go

@@ -1,3 +1,6 @@
+// Package runsimple is meant as a simple runner for osquery. It is initial just handling one off executions, but may
+// perhaps, expand to also handling daemonization
+
 package runsimple
 
 import (
@@ -109,29 +112,3 @@ func (p osqueryProcess) RunVersion(ctx context.Context) error {
 
 	return cmd.Run()
 }
-
-/*
-
-func (p *osqueryProcess) Execute(ctx context.Context) error {
-	// if this grows to replacing the larger osquery runtime, there are a lot of questions about how it will work.
-	//  - cmd.Start does not block, Need to call cmd.Wait after it, So how do we manage the start, health, wait in the rest of the control flow?
-	//  - Should osquery get it's own context? It makes some of the process management easier. But maybe not.
-
-}
-
-
-func (p *osqueryProcess) Stop() error {
-	proc := p.cmd.Process
-	if proc == nil {
-		return errors.New("No process. Missing start?")
-	}
-
-	err := cmd.Process.Signal(interrupt)
-	if err == nil {
-		err = ctx.Err() // Report ctx.Err() as the reason we interrupted.
-	} else if err.Error() == "os: process already finished" {
-		errc <- nil
-	}
-
-}
-*/