Add additional GH hosted runners to the smoke tests #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James-Pickett
previously approved these changes
Aug 2, 2023
directionless
force-pushed
the
seph/more-os
branch
from
587339a
to
792c155
Compare
directionless
commented
Aug 3, 2023
James-Pickett
previously approved these changes
Aug 3, 2023
RebeccaMahany
previously approved these changes
Aug 3, 2023
James-Pickett
approved these changes
Aug 3, 2023
RebeccaMahany
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #1276
This adds additional runners to the Exec Test section, and expands it to use both
launcher --versionandlauncher doctor.Because it expands the smoke test targets, I've also pulled the Upload into it's own job. That way we don't run upload for each smoke test.
And to support
doctorwe also need to have osquery installed. So I've added a launcher subcommand to support that