Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get build prefix for upgrade table from sysctl instead of osquery #1347

Merged
merged 1 commit into from
Sep 12, 2023
Merged

get build prefix for upgrade table from sysctl instead of osquery #1347

merged 1 commit into from
Sep 12, 2023

Conversation

zackattack01
Copy link
Contributor

This is part 1 to begin addressing #1338 (reducing osquery socket contention)

This replaces the osquery os_version table with a unix.Sysctl() call to get the build train prefix used to gather the rest of the macos software update table data. This change should only impact macos

@zackattack01 zackattack01 added this pull request to the merge queue Sep 12, 2023
Merged via the queue into main with commit 67c7920 Sep 12, 2023
25 checks passed
@zackattack01 zackattack01 deleted the reduce_osquery_socket_contention branch September 12, 2023 18:57
directionless
directionless approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is okay, but I wonder if there are places we can test to be sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@James-Pickett James-Pickett James-Pickett approved these changes

@directionless directionless directionless approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zackattack01 @directionless @James-Pickett