Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ship and autoupdate to osquery app bundle #1351

Merged
merged 14 commits into from
Oct 13, 2023
Merged

Ship and autoupdate to osquery app bundle #1351

merged 14 commits into from
Oct 13, 2023

Conversation

RebeccaMahany
Copy link
Contributor

@RebeccaMahany RebeccaMahany commented Sep 13, 2023 •
edited
Loading

Requires https://github.com/kolide/endpoint-releaser/pull/115

  • Updates package-builder to include the osquery app bundle in the .pkg
  • Updates new autoupdater to find executable within osquery.app directory when downloaded (the legacy autoupdate code in findnew.go already correctly handles finding the path to osquery.app's executable)
  • Adds tests to Test install macOS job
Testing notes
  • Tested building a pkg with package-builder -- test steps largely mirror the ones documented in Packaging for app bundle #934
  • Moved an osquery app bundle into the legacy updates directory to ensure that launcher could find it there
  • Moved an osquery app bundle into the new updates directory to ensure that launcher could find it there

@RebeccaMahany RebeccaMahany marked this pull request as ready for review October 11, 2023 20:49
James-Pickett
James-Pickett previously approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@James-Pickett James-Pickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

directionless
directionless previously approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a small addition to the launcher app bundle work. Nice

pkg/autoupdate/tuf/ci/tuf_server.go Show resolved Hide resolved
@RebeccaMahany RebeccaMahany added this pull request to the merge queue Oct 13, 2023
Merged via the queue into kolide:main with commit e88f064 Oct 13, 2023
24 checks passed
@RebeccaMahany RebeccaMahany deleted the becca/osquery-app-bundle branch October 13, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless approved these changes

@James-Pickett James-Pickett James-Pickett left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RebeccaMahany @directionless @James-Pickett