-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't trigger TUF when running from build directory #1607
Conversation
I don't think there will be a negative impact to doing this, so if you want it, sure. I am personally not in favor of adding this -- I don't think we need to add additional complexity to an already complicated system when there are already two other workarounds that meet this need during development ( |
I'm willing to hold while we figure out what we want, and how to cleanly handle it. Mostly, I want to be able to do things like |
|
If we believe that, then we should make it part of the development environment. I'm not totally sure how we'd want to do that. And I kinda feel mixed. I like things to just DTRT when possible |
@directionless I think the discussion is getting long enough that we should move it to slack, or if you want to table it for our next team meeting -- I would like to know what "make it a part of the development environment" entails for you (plus I would also like to know if |
e3ef6dc
to
9cf061b
Compare
We discussed this today, and I think concluded we should merge it. |
The old updater had the side effect of not triggering the update check when running from a build dir. I found that quite convenient, as I'm often running launcher in a development cycle. This recreates that behavior with a somewhat klunky path check.
If y'all think it will have some unknown impact around CI or testing, speak up...