add osquery restart history to checkups #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RebeccaMahany
previously approved these changes
Mar 1, 2024
directionless
previously approved these changes
Mar 1, 2024
|
|
||
| restartHistory, err := history.GetHistory() | ||
| if err != nil && errors.Is(err, history.NoInstancesError{}) { | ||
| orc.status = Passing |
There was a problem hiding this comment.
Consider whether this is Passing or Informational.
There was a problem hiding this comment.
Good catch, Informational does seem more appropriate here I will update
zackattack01
dismissed stale reviews from directionless and RebeccaMahany
via
4bcd88e
RebeccaMahany
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add a checkup to include the osquery restart history instances for doctor + flare.
This should close #1071